Fix conda named environment creation after conda 25.11 - #1643
Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit intoJul 22, 2026
Merged
Conversation
Closed
2 tasks
Jannis Leidel (jezdez)
marked this pull request as ready for review
July 20, 2026 19:45
Jannis Leidel (jezdez)
force-pushed
the
fix/conda-env-prefix-discovery
branch
from
July 20, 2026 21:02
dcedeaa to
2cf3ac7
Compare
Eduardo Villalpando Mello (edvilme)
added
the
bug
Eduardo Villalpando Mello (edvilme)
approved these changes
Jul 21, 2026
Eduardo Villalpando Mello (edvilme)
left a comment
Eduardo Villalpando Mello (edvilme)
left a comment
Contributor
There was a problem hiding this comment.
LGTM :)
| const state = await getWorkspacePersistentState(); | ||
| const storedPrefixes = await state.get<string[]>(CONDA_PREFIXES_KEY); | ||
| if (storedPrefixes && Array.isArray(storedPrefixes)) { | ||
| if (Array.isArray(storedPrefixes) && storedPrefixes.length > 0) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (Array.isArray(storedPrefixes) && storedPrefixes.length > 0) { | |
| if (storedPrefixes?.length > 0) { |
Contributor
Author
There was a problem hiding this comment.
This doesn't compile with strict TypeScript since storedPrefixes can still be undefined. I'd keep the current check.
Eleanor Boyd (eleanorjboyd)
previously approved these changes
Jul 21, 2026
Eleanor Boyd (eleanorjboyd)
left a comment
Eleanor Boyd (eleanorjboyd)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Eduardo Villalpando Mello (edvilme)
requested changes
Jul 21, 2026
Stella Huang (StellaHuang95)
previously approved these changes
Jul 21, 2026
Don Jayamanne (DonJayamanne)
previously approved these changes
Jul 21, 2026
Jannis Leidel (jezdez)
dismissed stale reviews from Don Jayamanne (DonJayamanne), Stella Huang (StellaHuang95), and Eleanor Boyd (eleanorjboyd)
via
July 22, 2026 19:18
5a9041a
Jannis Leidel (jezdez)
force-pushed
the
fix/conda-env-prefix-discovery
branch
from
July 22, 2026 19:18
2cf3ac7 to
5a9041a
Compare
Eduardo Villalpando Mello (edvilme)
approved these changes
Jul 22, 2026
Eduardo Villalpando Mello (edvilme)
left a comment
Eduardo Villalpando Mello (edvilme)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes Jannis Leidel (@jezdez) :) LGTM
Eleanor Boyd (eleanorjboyd)
approved these changes
Jul 22, 2026
Eduardo Villalpando Mello (edvilme)
enabled auto-merge (squash)
July 22, 2026 20:57
Stella Huang (StellaHuang95)
approved these changes
Jul 22, 2026
Eduardo Villalpando Mello (edvilme)
merged commit Jul 22, 2026
909ef65
into
microsoft:main
46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conda info --envs --jsonstopped includingenvs_dirsin conda 25.11. The extension persisted an empty prefix list and later searched it after conda had successfully created a named environment.This change:
envs_dirsfrom fullconda info --jsoninstead of the filtered--envsresponse--quiet --jsonand accepts both the current top-levelprefixand legacyactions.PREFIXReferences conda/conda#16430 and the named-environment failure in #1454.