Skip to content

Improve diagnostics.source.#14500

Closed
sean-mcmanus wants to merge 4 commits into
mainfrom
seanmcm/improveDiagnosticsSource
Closed

Improve diagnostics.source.#14500
sean-mcmanus wants to merge 4 commits into
mainfrom
seanmcm/improveDiagnosticsSource

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This is primarily for if/when microsoft/vscode#319418 gets fixed so Copilot can more easily know it's a not an actual C/C++ compiler error.

...but I figured it might help new users as well.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines the diagnostic.source strings used for diagnostics emitted by the C/C++ extension so consumers (e.g. Copilot) can distinguish IntelliSense, clang-tidy, and refactor diagnostics from generic "C/C++" compiler diagnostics. Introduces a new CppIntelliSenseSourceStr constant and updates the missing-include detection to match the new source value.

Changes:

  • Add CppIntelliSenseSourceStr ("C/C++ IntelliSense") and update isMissingIncludeDiagnostic to compare against it.
  • Tag clang-tidy and refactor diagnostics with more specific source strings ("C/C++ clang-tidy", "C/C++ Refactor").
  • Set IntelliSense diagnostics' source to CppIntelliSenseSourceStr in DefaultClient.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Extension/src/LanguageServer/extension.ts Adds the CppIntelliSenseSourceStr constant and updates the missing-include diagnostic check to use it.
Extension/src/LanguageServer/codeAnalysis.ts Tags clang-tidy diagnostics with the more specific "C/C++ clang-tidy" source.
Extension/src/LanguageServer/client.ts Imports the new constant, tags refactor diagnostics with "C/C++ Refactor", and sets IntelliSense diagnostics' source to CppIntelliSenseSourceStr.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sean-mcmanus sean-mcmanus requested a review from bobbrow June 1, 2026 22:42
@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

I want to make sure @bobbrow is okay with this before checking it in.

@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

Abandoned in favor or some alternative fix which allows us to tell Copilot specifically that the error is not a compiler error and is from our IntelliSense parser (which could be invalid/etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pull Request

Development

Successfully merging this pull request may close these issues.

3 participants