Skip to content

LEGO: Pull request from juno/hb_f2f230f9-08b4-4714-af00-6fce66aaeb84_20260903114657943 to main - #1677

Merged
Andrew Arnott (AArnott) merged 1 commit into
mainfrom
juno/hb_f2f230f9-08b4-4714-af00-6fce66aaeb84_20260903114657943
Sep 3, 2026
Merged

LEGO: Pull request from juno/hb_f2f230f9-08b4-4714-af00-6fce66aaeb84_20260903114657943 to main#1677
Andrew Arnott (AArnott) merged 1 commit into
mainfrom
juno/hb_f2f230f9-08b4-4714-af00-6fce66aaeb84_20260903114657943

Conversation

@csigs

Copy link
Copy Markdown
Member

LEGO: Pull request from juno/hb_f2f230f9-08b4-4714-af00-6fce66aaeb84_20260903114657943 to main with localized lcls

Copilot AI lite review requested due to automatic review settings September 3, 2026 11:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The newly added TRK strings have casing/wording inconsistencies (imperative form and “Task” usage) that should be normalized before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Turkish (TRK) localization resources for Microsoft.VisualStudio.Threading.Analyzers, adding new strings related to the VSTHRD202 analyzer and its code fixes.

Changes:

  • Added TRK-localized strings for VSTHRD202 title, message format, and code fix titles.
  • Introduced localized UI text for the “Remove async/await” code fix variants.
File summaries
File Description
loc/lcl/TRK/Microsoft.VisualStudio.Threading.Analyzers.dll.lcl Adds new TRK localization entries for VSTHRD202 analyzer and code fix UI strings.
Review details

Suppressed comments (2)

loc/lcl/TRK/Microsoft.VisualStudio.Threading.Analyzers.dll.lcl:756

  • This code fix title starts with lowercase "async"; for consistency with other UI strings and the other VSTHRD202 titles, consider starting with capitalized "Async".
            <Val><![CDATA[async ve await'i kaldırın, zaman uyumlu özel durumları döndürülen Task içinde sarın]]></Val>

loc/lcl/TRK/Microsoft.VisualStudio.Threading.Analyzers.dll.lcl:774

  • Analyzer title uses singular imperative ("kaldır") while the new VSTHRD202 code fix titles are phrased in the polite imperative form ("kaldırın"). Aligning the verb form improves consistency across these related strings.
            <Val><![CDATA[Gereksiz async durum makinesini kaldır]]></Val>
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread loc/lcl/TRK/Microsoft.VisualStudio.Threading.Analyzers.dll.lcl
Comment thread loc/lcl/TRK/Microsoft.VisualStudio.Threading.Analyzers.dll.lcl
@AArnott
Andrew Arnott (AArnott) merged commit 04b6973 into main Sep 3, 2026
10 checks passed
@AArnott
Andrew Arnott (AArnott) deleted the juno/hb_f2f230f9-08b4-4714-af00-6fce66aaeb84_20260903114657943 branch September 3, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants