feat: add cross-language Spector tests for dollar-sign query params and discriminator without subtypes#10841
Open
iscai-msft wants to merge 4 commits into
Open
Conversation
Add DollarSign interface to parameters/query with scenarios for $filter, $top/$skip, and $orderby query parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add Fish model with @Discriminator but no extending models to single-discriminator tests. Covers get and put scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iscai-msft
added
the
lib:http-specs
iscai-msft
requested review from
AlitzelMendez,
chrisradek,
timotheeguerin and
witemple-msft
as code owners
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new cross-language Spector test scenarios identified from Go and TypeScript emitter bug fixes:
1. Dollar-sign prefixed query parameters (
parameters/query/DollarSign)Tests that emitters correctly handle
$-prefixed query parameter names on the wire (e.g.$filter,$top,$skip,$orderby). Common in OData-style APIs.2. Discriminated type without subtypes (
type/model/inheritance/single-discriminator)Tests a
@discriminator-decorated model with no extending subtypes. Emitters should still generate the polymorphic type infrastructure.Both scenarios include
main.tspdefinitions,mockapi.tsimplementations, and updatedspec-summary.md.