Remove obsolete transitive NuGet overrides from typespec-vs#10824
Remove obsolete transitive NuGet overrides from typespec-vs#10824Copilot wants to merge 5 commits into
Conversation
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
commit: |
|
@copilot add changelog |
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
All changed packages have been documented.
Show changes
|
| Link="TextMate/typespec.tmLanguage" /> | ||
| <Content Update="@(Content)" IncludeInVSIX="true" CopyToOutputDirectory="PreserveNewest" /> | ||
| <Reference Include="System.ComponentModel.Composition" /> | ||
| <!-- The 'MessagePack' is not used directly but referenced by nuget package 'Microsoft.VisualStudio.SDK', 'Microsoft.VisualStudio.Workspace' and 'Microsoft.VisualStudio.VSIntegration' --> |
There was a problem hiding this comment.
but I don't see change to these nuget packages using the removed ones. They should be upgrade to a new version to use a security issue free dependency, shouldn't it?
There was a problem hiding this comment.
wouldn't that fail the CI if it did? did we maybe upgrade those version separately but never cleaned up?
@copilot can you investigate and check if that is the case, do we also need to upgrade the other packages?
There was a problem hiding this comment.
I checked the resolved graph with dotnet restore Microsoft.TypeSpec.VS.sln, dotnet list src/Microsoft.TypeSpec.VS.csproj package --include-transitive, and --vulnerable. The removed packages are still brought in transitively at the same resolved versions (MessagePack 2.5.192, Microsoft.VisualStudio.Composition 17.13.41, Microsoft.VisualStudio.Shell.15.0 17.14.40264), and NuGet reports no vulnerable packages for this project. So this looks like a cleanup of old explicit overrides after the upstream Visual Studio package set had already been updated, not a missing upgrade in this PR.
The Visual Studio extension was carrying explicit NuGet references that were only needed to suppress older transitive vulnerability and NU1603 issues. Those overrides are no longer necessary with the currently resolved Visual Studio package set.
Dependency cleanup
PackageReferences for:MessagePackMicrosoft.VisualStudio.CompositionMicrosoft.VisualStudio.Shell.15.0Project file simplification
Result
typespec-vsnow relies on the Visual Studio packages to supply these dependencies instead of pinning them redundantly in the project file.