Conversation
[copilot speaking] Require std for examples that construct GlobalPool and enable nightly coverage attributes in fetch_hyper's non-test library build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 472653a5-810d-4900-ae97-88692eff4e58
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed coverage configuration fixes are complete with no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Fixes isolated coverage builds by gating std-dependent examples and enabling coverage attributes in fetch_hyper.
Changes:
- Added
required-features = ["std"]to sixbytesbufexamples. - Enabled
coverage_attributewhencoverage_nightlyis active.
| File | Description |
|---|---|
crates/bytesbuf/Cargo.toml |
Gates std-dependent examples on std. |
crates/fetch_hyper/src/lib.rs |
Enables coverage attributes for instrumented builds. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
==========================================
Coverage 100.0% 100.0%
==========================================
Files 738 244 -494
Lines 98471 27795 -70676
==========================================
- Hits 98471 27795 -70676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[copilot speaking] Package-isolated coverage tests exposed two defects hidden by batched workspace builds: bytesbuf examples using the std-only GlobalPool lacked
required-features, and fetch_hyper usedcoverage(off)in a non-test build without enablingcoverage_attribute.The examples now require
std, and fetch_hyper enables the attribute when instrumented. The crate fixes pass targeted isolated checks. Temporary generated Anvil recipe edits are excluded: the experimental full-workspace isolated run added 14m49s and failed the seatbelt coverage gate, so the upstream recipe change is deferred.