fix(langchain): stop overriding Azure request models - #225
Draft
Jackson Weber (JacksonWeber) wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the distro workaround for callback payloads corrected by langchainjs#10886 and retain only request-first model precedence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Wait to mark for review until langchain-ai/langchainjs#10886 is merged/released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen_ai.response.modelindependently fromgen_ai.request.modelWhy a distro change remains
The distro currently detects bare
AzureChatOpenAIruns and always prefers the server-reported response model forgen_ai.request.model. Once LangChain reports the configured deployment correctly, that workaround would overwrite the trustworthy request model.This PR removes the Azure special case:
The response model remains populated separately when available.
Upstream dependency
This cleanup relies on the LangChain release containing langchain-ai/langchainjs#10886. That release must be used before shipping this change; older LangChain versions that report the unrelated
gpt-3.5-turbodefault will no longer receive a distro-side workaround.Validation