Fix races in Linux file descriptor duplication - #1181
Merged
Conversation
Weiteng Chen (CvvT)
marked this pull request as ready for review
August 17, 2026 17:46
Weidong Cui (wdcui)
requested a review
from Jay Bosamiya (Microsoft) (jaybosamiya-ms)
August 17, 2026 19:14
Member
|
Jay Bosamiya (Microsoft) (@jaybosamiya-ms) maybe you should review this fd-related fix? |
Weiteng Chen (CvvT)
force-pushed
the
weiteng/fix_dup
branch
2 times, most recently
from
August 17, 2026 22:09
c0193ca to
69362a3
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
left a comment
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
left a comment
Member
There was a problem hiding this comment.
Generally seems reasonable to me, just a couple of points; the biggest being that I am not sure why max_fd changed to fd_limit as part of this change; seems unrelated to the goal of this PR to fix the races, no?
Weiteng Chen (CvvT)
force-pushed
the
weiteng/fix_dup
branch
from
September 1, 2026 18:52
7ec5050 to
f70aaee
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
approved these changes
Sep 1, 2026
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
left a comment
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks Weiteng!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1170: keep FD allocation and exact replacement atomic under the raw descriptor table lock.