fix: replace blocking synchronous I/O with async httpx in CDP browser startup#61
Open
rahulrao85 wants to merge 1 commit into
Open
fix: replace blocking synchronous I/O with async httpx in CDP browser startup#61rahulrao85 wants to merge 1 commit into
rahulrao85 wants to merge 1 commit into
Conversation
… startup The _is_local_cdp_available, _local_cdp_page_targets, and _ensure_local_cdp_page_target functions used blocking urllib.request and time.sleep() inside async methods, blocking the asyncio event loop for up to 10 seconds. Changes: - Replace synchronous urllib.request with httpx.AsyncClient (httpx is already a dependency) - Replace time.sleep() with asyncio.sleep() in the CDP polling loop - Convert _ensure_local_cdp_browser to async - Remove unused urllib imports Fixes: microsoft#56
|
@rahulrao85 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CDP browser startup helpers used blocking \urllib.request\ and \ ime.sleep()\ inside async methods, blocking the asyncio event loop for up to 10 seconds. This is particularly problematic because the agent loop cannot make progress or be cancelled during CDP polling.
Changes
Fixes: #56