Add diagnostic logging to GetFileStreamException catch block#1996
Merged
Conversation
The GetFileStreamException catch in GetFileStreamHandlerAsyncHandler silently completed the ProjFS command without logging requestMetadata (SHA, virtual path). Other catch blocks in the same handler all log this metadata. Add a RelatedWarning with the HResult value for diagnostic visibility while keeping the severity appropriate for expected/benign HResult.Handle results. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
derrickstolee
approved these changes
Jun 2, 2026
Contributor
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
Good find. Obvious solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetFileStreamExceptioncatch inGetFileStreamHandlerAsyncHandlersilently completed the ProjFS command without loggingrequestMetadata(SHA, virtual path). The other catch blocks in the same handler (OperationCanceledException, genericException) all log this metadata.This adds a
RelatedWarninglog call with the HResult value beforeTryCompleteCommand, providing diagnostic visibility while keeping the severity appropriate for expected/benignHResult.Handleresults.