Avoid async IPC panic on peer close - #64142
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Open
Conversation
Track in-flight request handlers and propagate response write failures through Run instead of panicking from detached goroutines. Cancel handlers during connection shutdown and preserve concurrent errors.
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 3, 2026 04:36
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The critical unbounded teardown wait must be fixed and covered by a regression test.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prevents async IPC response-write panics after peer closure, but introduces potentially indefinite teardown blocking.
Changes:
- Propagates response-write failures through
Run. - Adds a peer-close regression test.
File summaries
| File | Description |
|---|---|
tsc/internal/ipc/conn_async.go |
Tracks handlers, but synchronously waiting can block teardown indefinitely. |
tsc/internal/ipc/conn_async_test.go |
Tests peer closure, but does not cover a handler remaining blocked. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| defer func() { | ||
| cancel() | ||
| c.closePendingCalls(err) | ||
| c.handlers.Wait() |
Report completed request errors without synchronously draining request handlers during connection teardown. Cover peer closure while a handler remains blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to fix the race condition hit in CI: https://github.com/microsoft/TypeScript/actions/runs/33681309624/job/100418285983