Prevent infinite loop in unstable AST JSDoc scanner - #64141
Open
Jake Bailey (jakebailey) with Copilot wants to merge 3 commits into
Open
Prevent infinite loop in unstable AST JSDoc scanner#64141Jake Bailey (jakebailey) with Copilot wants to merge 3 commits into
Jake Bailey (jakebailey) with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix infinite loop in scanJsDocToken for unstable/ast
Prevent infinite loop in unstable AST JSDoc scanner
Sep 3, 2026
Jake Bailey (jakebailey)
approved these changes
Sep 3, 2026
Jake Bailey (jakebailey)
marked this pull request as ready for review
September 3, 2026 04:37
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 3, 2026 04:37
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix correctly addresses the precedence bug and includes matching regression coverage.
Pull request overview
Fixes an infinite loop in the unstable AST JSDoc scanner when a scan range ends with a hyphen.
Changes:
- Correctly bounds hyphenated identifier scanning.
- Adds regression coverage for EOF and token preservation.
File summaries
| File | Description |
|---|---|
packages/typescript/src/ast/scanner.ts |
Fixes the scanner range condition. |
packages/typescript/test/scanner.test.ts |
Tests trailing-hyphen range scanning. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unstable AST JSDoc scanner could loop indefinitely when a scan range ended immediately after
-, because the range check did not guard the full identifier condition.Changes
pos < end:x-reaches EOF and preserves the expected tokens.