Clarify charCodeAt and codePointAt documentation#63471
Open
MukundaKatta wants to merge 1 commit into
Open
Conversation
Member
|
How did you determine that this is a bug worth fixing, given what our contributing doc says at the top? What tool did you use to send this PR? |
Author
|
I used VS Code with GitHub Copilot assistance for drafting/editing, but I reviewed and prepared the final change manually before submitting the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49561
This updates the library JSDoc for
Stringmethods to use more precise terminology:charCodeAtnow describes returning a UTF-16 code unit value rather than an ambiguous Unicode value.codePointAtnow explicitly says Unicode code point while preserving the existing UTF-16/surrogate-pair details for indexing behavior.Validation: