fix(qwen): always send explicit enable_thinking in chat_template_kwargs#109
Open
LESdylan wants to merge 1 commit into
Open
fix(qwen): always send explicit enable_thinking in chat_template_kwargs#109LESdylan wants to merge 1 commit into
LESdylan wants to merge 1 commit into
Conversation
When enable_thinking=false the payload previously omitted chat_template_kwargs entirely, leaving thinking mode to the vLLM server / chat-template default — which varies across deployments and made runs hard to reproduce (microsoft#90). Send an explicit true/false always, matching the MiniMax backend's existing behavior. Ref microsoft#90
Contributor
|
@LESdylan please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
skillopt/model/qwen_backend.pyonly attachedchat_template_kwargswhenenable_thinkingwas true:With
enable_thinking=falsethe key was omitted entirely, so whether Qwen thinking mode ran was decided by the vLLM server / chat-template default — which varies across deployments and makes results hard to reproduce. This is exactly point 3 of #90, where @Huangzisu confirmed the reported results used client-sideenable_thinking=falseand that the code would be adjusted.Change
Always send an explicit boolean:
This matches the MiniMax backend, which already sends the flag unconditionally (
minimax_backend.py).Tests
Updated the two tests that pinned the omit-when-disabled behavior to assert an explicit
{"enable_thinking": False}instead. Full suite: 165 passed, 5 skipped.Ref #90