Expose runtime batch message indexes - #28258
Draft
Kian Thompson (kian-thompson) wants to merge 3 commits into
Draft
Kian Thompson (kian-thompson) wants to merge 3 commits into
Kian Thompson (kian-thompson) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aef35cc-ec67-4c9e-b9f5-9d78efe9ab88
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (571 lines, 40 files), I've queued these reviewers:
How this works
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aef35cc-ec67-4c9e-b9f5-9d78efe9ab88
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8aef35cc-ec67-4c9e-b9f5-9d78efe9ab88
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Contributor
Bundle size comparisonBase commit: Notable changes
Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runtime messages currently use
clientSequenceNumberas an ordering key, but that value does not consistently represent a logical message's position after grouped batches are unpacked. This change introduces an explicit runtime batch index and forwards it through the container runtime, data store runtime, and shared object event layers.What is changing
ISequencedRuntimeMessagetype with an optionalindexInBatchproperty.indexInBatchfor grouped, ungrouped, and singleton runtime batches.fluid-frameworklegacy surface.SharedDirectoryordering to preferindexInBatch, withclientSequenceNumberretained as a compatibility fallback.Rollout plan
indexInBatchremains optional so newer data store packages can operate across older runtime package boundaries. Runtime generation 10 advertises support when available, and all generation 11 runtimes are expected to provide the field. Consumers should temporarily fall back toclientSequenceNumberonly when the new field is absent.After the three-generation compatibility window excludes runtimes without this capability, the feature can become required and the runtime-layer
clientSequenceNumberfallback can be removed in an eligible beta-breaking release, no earlier than 3.10.Reviewer Guidance
The review process is outlined in the pull request guidelines.
The main areas to review are the batch-index assignment in the container runtime, preservation across runtime-layer boundaries, and the compatibility fallback used by
SharedDirectory.