Skip to content

fix(website): clarify homepage link accessible names - #28256

Open
shlevari wants to merge 1 commit into
microsoft:mainfrom
shlevari:wi83302-link-accessible-names
Open

shlevari wants to merge 1 commit into
microsoft:mainfrom
shlevari:wi83302-link-accessible-names

Conversation

@shlevari

@shlevari shlevari commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Updates homepage "Learn more" links to use unique accessible names in the form "Learn more about <title>". This keeps the visible label at the beginning of each accessible name while providing enough context to distinguish links for key features, services, and partners.

Removes redundant accessible-name props and adds Playwright coverage for every affected homepage link.

AB#83302

Reviewer Guidance

The review process is outlined in the pull request guidelines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added base: main PRs targeted against main branch documentation Improvements or additions to documentation area: tools area: repo Repo related work area: website and removed base: main PRs targeted against main branch labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (81 lines, 5 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@shlevari
shlevari marked this pull request as ready for review September 18, 2026 22:52
Copilot AI lite review requested due to automatic review settings September 18, 2026 22:52
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: could not be determined; will be reported when the comparison runs
Head commit: 0212c8efceb8c9b168f3b287db70b86aac95f32e

Pending — Build - client packages is running. Results will appear here when the build completes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Updates homepage “Learn more” links with unique, visible-label-first accessible names and adds Playwright coverage.

Changes:

  • Adds contextual Learn more about <title> labels.
  • Removes redundant accessible-name props.
  • Tests all affected homepage links.
File Description
website/​test/​site-tests/​Accessibility.spec.ts Adds coverage for homepage link names.
website/​src/​components/​home/​serviceSection.tsx Updates service link names and props.
website/​src/​components/​home/​partnersSection.tsx Updates partner link names and props.
website/​src/​components/​home/​keyFeaturesSection.tsx Removes redundant props.
website/​src/​components/​home/​keyFeatureCard.tsx Updates key-feature link names.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

$ start-server-and-test "npm run serve -- --host 127.0.0.1 --no-open" http://127.0.0.1:3000 check-links
1: starting server using command "npm run serve -- --host 127.0.0.1 --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --host 127.0.0.1 --no-open

[SUCCESS] Serving "build" directory at: http://127.0.0.1:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://127.0.0.1:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  658102 links
    3579 destination URLs
    3898 URLs ignored
       0 warnings
       0 errors


@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Fleet Review — Clean

No issues found across the reviewer fleet for this run.

View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: repo Repo related work area: tools area: website documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants