build(client-client-utils): fix incremental test build - #28244
Jason Hartman (jason-ha) merged 1 commit into
Conversation
Jason Hartman (jason-ha)
commented
Sep 17, 2026
- "build:test:types" was missing "typetests:gen"
- "build:test:esm" needs customized per custom test builds
- "build:test:types" was missing "typetests:gen" - "build:test:esm" needs customized per custom test builds
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (9 lines, 1 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to fluidBuild task dependency wiring and align with existing task-definition patterns (script: false alias + explicit dependsOn) without introducing unresolved build-graph issues.
Pull request overview
This PR updates @fluid-internal/client-utils’s fluidBuild task graph so incremental “test build” tasks correctly include typetest generation and so build:test:esm exists for this package (which previously lacked a build:test:esm script).
Changes:
- Adds a
fluidBuild.tasks.build:test:esmalias task (script: false) that depends on the package’s existing ESM mocha, playwright, and type-test build tasks. - Updates
fluidBuild.tasks.build:test:typesto depend ontypetests:genbefore building.
File summaries
| File | Description |
|---|---|
| packages/common/client-utils/package.json | Adjusts fluidBuild task dependencies to generate typetests for build:test:types and define an alias build:test:esm task for incremental test builds. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|