Skip to content

build(client-client-utils): fix incremental test build - #28244

Merged
Jason Hartman (jason-ha) merged 1 commit into
microsoft:mainfrom
jason-ha:build/fix-esm-build-for-client-utils
Sep 23, 2026
Merged

Jason Hartman (jason-ha) merged 1 commit into
microsoft:mainfrom
jason-ha:build/fix-esm-build-for-client-utils

Conversation

@jason-ha

Copy link
Copy Markdown
Contributor
  • "build:test:types" was missing "typetests:gen"
  • "build:test:esm" needs customized per custom test builds

- "build:test:types" was missing "typetests:gen"
- "build:test:esm" needs customized per custom test builds
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (9 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to fluidBuild task dependency wiring and align with existing task-definition patterns (script: false alias + explicit dependsOn) without introducing unresolved build-graph issues.

Pull request overview

This PR updates @fluid-internal/client-utils’s fluidBuild task graph so incremental “test build” tasks correctly include typetest generation and so build:test:esm exists for this package (which previously lacked a build:test:esm script).

Changes:

  • Adds a fluidBuild.tasks.build:test:esm alias task (script: false) that depends on the package’s existing ESM mocha, playwright, and type-test build tasks.
  • Updates fluidBuild.tasks.build:test:types to depend on typetests:gen before building.
File summaries
File Description
packages/common/client-utils/package.json Adjusts fluidBuild task dependencies to generate typetests for build:test:types and define an alias build:test:esm task for incremental test builds.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: adce2b48229296c2759802a05c686f98ebd0974e
Head commit: ee1c84da8999f5a4bec2a39d9c0fd4e8d17a6384

Notable changes

No bundles changed by ≥ 500 bytes parsed.

Per-bundle deltas

@fluid-example/bundle-size-tests

  • fluidFrameworkAllAlpha.js: parsed 805988 → 806042 (+54), gzip 221392 → 221476 (+84)
  • azureClient.js: parsed 634336 → 634331 (-5), gzip 169989 → 170074 (+85)
  • odspClient.js: parsed 606600 → 606711 (+111), gzip 163052 → 163198 (+146)
  • aqueduct.js: parsed 538752 → 538763 (+11), gzip 144632 → 144680 (+48)
  • fluidFramework.js: parsed 415378 → 415411 (+33), gzip 117810 → 117844 (+34)
  • sharedTree.js: parsed 404757 → 404783 (+26), gzip 115252 → 115270 (+18)
  • containerRuntime.js: parsed 315027 → 315009 (-18), gzip 86438 → 86439 (+1)
  • sharedString.js: parsed 175732 → 175739 (+7), gzip 49785 → 49795 (+10)
  • experimentalSharedTree.js: parsed 161846 → 161846 (0), gzip 46722 → 46722 (0)
  • matrix.js: parsed 153720 → 153727 (+7), gzip 44381 → 44388 (+7)
  • loader.js: parsed 147328 → 147344 (+16), gzip 40038 → 40049 (+11)
  • odspDriver.js: parsed 106695 → 106753 (+58), gzip 33227 → 33293 (+66)
  • directory.js: parsed 65669 → 65676 (+7), gzip 18493 → 18502 (+9)
  • 578.js: parsed 58686 → 58686 (0), gzip 17657 → 17657 (0)
  • odspPrefetchSnapshot.js: parsed 46463 → 46444 (-19), gzip 15512 → 15522 (+10)
  • map.js: parsed 45820 → 45827 (+7), gzip 14120 → 14127 (+7)
  • 252.js: parsed 44384 → 44384 (0), gzip 13741 → 13741 (0)
  • summarizerDelayLoadedModule.js: parsed 31287 → 31287 (0), gzip 7929 → 7929 (0)
  • socketModule.js: parsed 27108 → 27078 (-30), gzip 8069 → 8103 (+34)
  • createNewModule.js: parsed 12464 → 12464 (0), gzip 4792 → 4805 (+13)
  • summaryModule.js: parsed 3888 → 3888 (0), gzip 1874 → 1874 (0)
  • connectionState.js: parsed 909 → 909 (0), gzip 500 → 500 (0)
  • sharedTreeAttributes.js: parsed 845 → 852 (+7), gzip 496 → 505 (+9)
  • debugAssert.js: parsed 429 → 429 (0), gzip 299 → 299 (0)
  • FluidFramework-HashFallback.js: parsed 419 → 419 (0), gzip 313 → 313 (0)

@jason-ha
Jason Hartman (jason-ha) merged commit 47c3abe into microsoft:main Sep 23, 2026
34 checks passed
@jason-ha
Jason Hartman (jason-ha) deleted the build/fix-esm-build-for-client-utils branch September 23, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: repo Repo related work area: tools area: website base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants