Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (205 lines, 3 files), I've queued these reviewers:
How this works
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Fleet Review — CleanNo issues found across the reviewer fleet for this run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
stripSoftBreaksso it preserves the structural newline after a valid GitHub admonition marker without introducing newlines for marker-like text elsewhere.Previously, soft breaks were removed before admonition markers were examined, which erased whether
[!NOTE]appeared on its own source line. The transform then reconstructed line breaks from the flattened text, incorrectly treating same-line content as an admonition and inserting breaks before marker-like text in blockquote bodies.The new test suite covers all supported admonition types, trailing whitespace, block content, body normalization, same-line markers, later markers, and unsupported marker forms.
Reviewer Guidance
The review process is outlined in the pull request guidelines.
The key behavior to review is that admonition recognition now uses the original Markdown AST structure before soft-break normalization.