Conversation
The allow list carries icu.dll but not the two ICU component libraries that Windows ships next to it, icuuc.dll and icuin.dll. All three are present in System32 through Windows Server 2025. Because of that, the FIP-FS processes that do text extraction and scanning, ParserServer and scanningprocess, report both libraries as unexpected modules on every run, which is noise that hides the findings that matter.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped allowlist update has no unresolved blocking issues.
Pull request overview
Updates the AV exclusions tester to recognize Windows Server 2025 ICU component libraries.
Changes:
- Adds
icuuc.dllandicuin.dllto the module allowlist.
File summaries
| File | Description |
|---|---|
Diagnostics/AVTester/Test-ExchAVExclusions.ps1 |
Allows the two ICU component DLLs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allow list carries
icu.dllbut not the two ICU component libraries that Windows ships next to it,icuuc.dllandicuin.dll. All three are present in System32 through Windows Server 2025.Because of that, the FIP-FS processes that do text extraction and scanning, ParserServer and scanningprocess, report both libraries as unexpected modules on every run, which is noise that hides the findings that matter.
Sample output before the change:
.build\CodeFormatter.ps1, cspell and.build\Build.ps1all pass.