Add missing telemetry event IDs to E-Document Session.LogMessage calls - #9872
Open
Groenbech96 wants to merge 1 commit into
Open
Add missing telemetry event IDs to E-Document Session.LogMessage calls#9872Groenbech96 wants to merge 1 commit into
Groenbech96 wants to merge 1 commit into
Conversation
21 `Session.LogMessage` call sites passed an empty string ('') as the
telemetry event ID, so the emitted traces could not be aggregated or
alerted on by event ID.
All 20 `Session.LogMessage` calls in the Avalara E-Document connector
were untagged, making that app effectively invisible in telemetry when
querying by event ID. One further call in the core E-Document app
(EDocumentPEPPOLHandler) was also missing its tag.
Tags were allocated by `Expand-TelemetryTags` and cover the contiguous
range 0000UVW-0000UWG. Only the event ID literal changed on each line;
no message, verbosity, data classification, scope or custom dimension
was modified.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7f568c52-2a16-40db-828d-64ffd2dfb87b
github-actions
Bot
added
AL: Apps (W1)
Contributor
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
gggdttt
approved these changes
Jul 31, 2026
ventselartur
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
21
Session.LogMessagecall sites in the E-Document apps passed an empty string ('') as the telemetry event ID, so the traces they emit cannot be aggregated, filtered or alerted on by event ID in the standard telemetry pipeline.Most notably, every single
Session.LogMessagecall in the Avalara E-Document connector was untagged (20 of 20) — that app is effectively invisible in telemetry when querying by event ID. It does set'Category'custom dimensions, so the messages aren't completely untraceable, but they can't be grouped or monitored the normal way.One further call in the core E-Document app (
EDocumentPEPPOLHandler.Codeunit.al) was also missing its tag; the rest of that app already follows the convention.Change
Tags were allocated by running
Expand-TelemetryTags, which reserves IDs centrally, so there is no collision risk. They cover the contiguous range0000UVW–0000UWG.Avalara/App/src/Shared/AvalaraFunctions.Codeunit.al0000UVW–0000UW0Avalara/App/src/Documents/AvalaraDocumentManagement.Codeunit.al0000UW1–0000UW5Avalara/App/src/Connection/HttpExecutor.Codeunit.al0000UW6–0000UW9Avalara/App/src/Maintenance/Maintenance.Codeunit.al0000UWA–0000UWCAvalara/App/src/Activation/Activation.Codeunit.al0000UWD,0000UWEAvalara/App/src/Integration/Processing.Codeunit.al0000UWFEDocument/App/src/Processing/Import/StructureReceivedEDocument/EDocumentPEPPOLHandler.Codeunit.al0000UWG