[MAIN]-Bug 644801-IRS Reporting Period - Copy Setup process will copy the 1099 Adjustments as part of the process of copying from one IRS Reporting Period to a new Period setup. - #9868
Open
v-praghav wants to merge 1 commit into
Open
Conversation
ventselartur
approved these changes
Jul 31, 2026
v-praghav
marked this pull request as ready for review
July 31, 2026 16:52
| LibraryTestInitialize.OnAfterTestSuiteInitialize(Codeunit::"IRS Reporting Period Tests"); | ||
| end; | ||
|
|
||
| [MessageHandler] |
Contributor
There was a problem hiding this comment.
CopySetupMessageHandler is an empty [MessageHandler] with no Enqueue/Dequeue verification, so the new test VendorFormBoxAdjustmentAmountIsResetWhenCopyingSetup only proves that some Message(...) call was raised during CopyPeriodSetup. It never asserts the expected message text (e.g. via LibraryVariableStorage.Enqueue/Dequeue and Assert.ExpectedMessage) or that it fired the expected number of times, so the test would stay green even if the wrong message, or an unexpected extra message, were shown.
Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.26.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Issue: Copy Setup was incorrectly carrying 1099 adjustment amounts from source period to target period.
Cause: The copy logic duplicated the full adjustment record, including the Amount field, instead of resetting it for the new period.
Linked work
AB#644801
Fixes #
Solution: Update copy logic to explicitly set Amount = 0 before insert in target period, and add an automated test to validate this behavior during setup copy.
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility