Skip to content

[Subcontracting] Added assisted setup guide for initial app configuration - #9818

Open
6CRIPT wants to merge 6 commits into
mainfrom
bugs/642233-app-installation-opens-Manufacturing-Setup-without-visible-Subcontracting-fields
Open

[Subcontracting] Added assisted setup guide for initial app configuration#9818
6CRIPT wants to merge 6 commits into
mainfrom
bugs/642233-app-installation-opens-Manufacturing-Setup-without-visible-Subcontracting-fields

Conversation

@6CRIPT

@6CRIPT 6CRIPT commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This PR adds an app-owned, three-step assisted setup guide for Subcontracting. The guide lets users review company defaults and navigate to the remaining configuration pages without relying on Manufacturing Setup during the installation session. Manufacturing Setup remains available through Manual Setup for later maintenance.

Also tests added.

Fixes AB#642233

@6CRIPT
6CRIPT requested a review from a team July 29, 2026 10:53
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 29, 2026
@6CRIPT 6CRIPT assigned 6CRIPT and unassigned 6CRIPT Jul 29, 2026
@6CRIPT
6CRIPT enabled auto-merge July 29, 2026 10:55
@github-actions github-actions Bot added the SCM GitHub request for SCM area label Jul 29, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 29, 2026
Comment thread src/Apps/W1/Subcontracting/App/src/Permissions/SubcontractObjs.PermissionSet.al Outdated
Comment thread src/Apps/W1/Subcontracting/App/src/Setup/SubcontractingSetupGuide.Page.al Outdated
Comment thread src/Apps/W1/Subcontracting/App/src/Setup/SubcontractingSetupGuide.Page.al Outdated
Comment thread src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al Outdated
@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as low quality.

@github-actions

This comment was marked as duplicate.

@6CRIPT

6CRIPT commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

QUICK CONTEXT: The PR is about an assisted setup for the subcontracting extension.

The last copilot comment states basically that, once the Subcontracting setup is completed at least one time, if the user tries to run it again for some reason and then he leaves before finishing the setup, it will get a warning saying that the setup is not completed.

Copilot asks for the local variable SetupCompleted: Boolean; to initialize with the persisted value, so as soon as the extension is setup, the persisted value will store a TRUE.

What I think is the complete opposite, using ALWAYS a initial value of FALSE is better (in my opinion) because it warns the user the CURRENT process has not been completed (which is true). Therefore I would keep it.

However this is a personal opinion on the approach and actually both make sense and are correct. It depends of the perspective.

This is why I need third opinions. :)

NOTE: I did not found a clear pattern in other setups.

More context:

So we have the new set up:

menu

With the 3 steps:
wiz1
wiz2
wiz3

Once you press the "Finish" button, its properly set up.
But if you try to set it up again, and in the middle of the process you try to exit, you get the warning:

warning

But the extension is properly installed. Therefore copilot suggest that this warning should go. I don't agree because I think that this warning should stay because it notifies the user that he is leaving without finishing the (new) set up, regardless of being one completed already.

@6CRIPT
6CRIPT force-pushed the bugs/642233-app-installation-opens-Manufacturing-Setup-without-visible-Subcontracting-fields branch from 661b1da to 2587b68 Compare July 31, 2026 08:51

@PredragMaricic PredragMaricic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings. The assisted setup wizard is coherently registered, permissioned, instrumented, and covered by focused UI tests.

@PredragMaricic PredragMaricic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings on the current head. The assisted setup object rename is consistent across registration, permissions, implementation, and tests, and removing the worksheet link keeps the final step focused on configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants