Fix E-Document purchase draft header Sub Total overwrite; notify on mismatch

src/Apps/W1/EDocument/App/docs/patterns.md

@@ -214,3 +214,29 @@ The codebase uses compiler directives to manage deprecation:
 - `#if not CLEANSCHEMA26` / `#if not CLEANSCHEMA29` -- table schema changes (field removals) that need separate cleanup due to schema migration constraints
 
 When reading the code, content inside these blocks is legacy. The code outside (or in the `#else` branch) is the current implementation.
+
+## Notification state vs. display
+
+Purchase Document Draft notifications are split across two codeunits so that a
+call site tells you whether UI is raised.
+
+`"E-Doc. Draft Notif. State"` (6436) owns the `E-Document Notification` rows, the
+Sub Total mismatch calculation, and its telemetry. It never constructs or sends a
+`Notification` and knows nothing about `My Notifications`.
+
+`"E-Document Notification"` (6123) is the only codeunit consumers call. It gates on
+`My Notifications`, delegates state changes downward, builds `Notification` objects,
+and hosts the `Dismiss…`/`Disable…` action handlers. The dependency is one-way.
+
+The procedure verb is the contract:
+
+| Prefix | Guarantee |
+|---|---|
+| `Add…` / `Refresh…` / `Remove…` / `ReArm…` | State only, never displays |
+| `Show…` / `RefreshAndShow…` | Displays a notification |
+| `Is…` | Query, no side effects |
+
+Handler names passed to `Notification.AddAction` are resolved by string at runtime,
+so `DismissSubTotalMismatchNotification` and friends cannot be renamed safely.
+
+*Updated: 2026-08-05 -- documented the notification state vs. display split.*

src/Apps/W1/EDocument/App/src/Document/Notification/EDocumentNotification.Table.al

@@ -39,6 +39,12 @@ table 6126 "E-Document Notification"
             Caption = 'Message';
             ToolTip = 'Specifies the message of the E-Document notification.';
         }
+        field(6; Dismissed; Boolean)
+        {
+            Caption = 'Dismissed';
+            DataClassification = SystemMetadata;
+            ToolTip = 'Specifies whether the user has dismissed the notification.';
+        }
     }
     keys
     {

src/Apps/W1/EDocument/App/src/Document/Notification/EDocumentNotificationType.Enum.al

@@ -16,4 +16,8 @@ enum 6126 "E-Document Notification Type"
     {
         Caption = 'Vendor Matched By Name Not Address';
     }
+    value(2; "Sub Total Mismatch")
+    {
+        Caption = 'Sub Total Mismatch';
+    }
 }

src/Apps/W1/EDocument/App/src/Processing/Import/Purchase/EDocPurchaseDraftSubform.Page.al

@@ -346,6 +346,7 @@ page 6183 "E-Doc. Purchase Draft Subform"
         TempEDocumentPOMatchWarnings: Record "E-Doc PO Match Warning";
         EDocPurchaseHistMapping: Codeunit "E-Doc. Purchase Hist. Mapping";
         EDocPOMatching: Codeunit "E-Doc. PO Matching";
+        EDocumentNotification: Codeunit "E-Document Notification";
         AdditionalColumns, OrderMatchedCaption, MatchWarningsCaption, MatchWarningsStyleExpr, MatchedEntityName : Text;
         LineAmount: Decimal;
         DimVisible1, DimVisible2, HasAdditionalColumns, IsEDocumentMatchedToAnyPOLine, IsLineMatchedToOrderLine, IsLineMatchedToReceiptLine, HasEDocumentOrderMatchWarnings, VATProdPostGroupIsVisible : Boolean;
@@ -382,6 +383,12 @@ page 6183 "E-Doc. Purchase Draft Subform"
         SetVATProductPostingGroupVisibility();
     end;
 
+    trigger OnDeleteRecord(): Boolean
+    begin
+        EDocumentNotification.RefreshAndShowSubTotalMismatchAfterLineDeletion(Rec);
+        exit(true);
+    end;
+
     internal procedure SetEDocumentPurchaseHeader(EDocPurchHeader: Record "E-Document Purchase Header")
     begin
         EDocumentPurchaseHeader := EDocPurchHeader;
@@ -407,10 +414,8 @@ page 6183 "E-Doc. Purchase Draft Subform"
         VATProdPostGroupIsVisible := PurchSetup."Resolve VAT Group Purch EDoc";
     end;
 
-    local procedure UpdateCalculatedAmounts(UpdateParentRecord: Boolean)
+    local procedure UpdateCalculatedAmounts(UserModifiedAmount: Boolean)
     var
-        TotalEDocPurchaseLine: Record "E-Document Purchase Line";
-        EDocumentImportHelper: Codeunit "E-Document Import Helper";
         LineSubtotal: Decimal;
         DiscountExceedsSubtotalErr: Label 'Discount should not exceed the subtotal of the line';
     begin
@@ -423,19 +428,9 @@ page 6183 "E-Doc. Purchase Draft Subform"
         else
             if Rec."Total Discount" / LineSubtotal > 1 then
                 Error(DiscountExceedsSubtotalErr);
-        if not UpdateParentRecord then
+        if not UserModifiedAmount then
             exit;
-        if not EDocumentPurchaseHeader.Get(Rec."E-Document Entry No.") then
-            exit;
-        EDocumentPurchaseHeader."Sub Total" := 0;
-        TotalEDocPurchaseLine.SetRange("E-Document Entry No.", Rec."E-Document Entry No.");
-        if TotalEDocPurchaseLine.FindSet() then
-            repeat
-                EDocumentPurchaseHeader."Sub Total" += Round(TotalEDocPurchaseLine.Quantity * TotalEDocPurchaseLine."Unit Price", EDocumentImportHelper.GetCurrencyRoundingPrecision(EDocumentPurchaseHeader."Currency Code")) - TotalEDocPurchaseLine."Total Discount";
-            until TotalEDocPurchaseLine.Next() = 0;
-        EDocumentPurchaseHeader.Total := EDocumentPurchaseHeader."Sub Total" + EDocumentPurchaseHeader."Total VAT" - EDocumentPurchaseHeader."Total Discount";
-        EDocumentPurchaseHeader.Modify();
-        CurrPage.Update();
+        EDocumentNotification.RefreshAndShowSubTotalMismatchAfterLineEdit(Rec);
     end;
 
     local procedure SetHasAdditionalColumns()

src/Apps/W1/EDocument/App/src/Processing/Import/Purchase/EDocumentPurchaseDraft.Page.al

@@ -214,6 +214,7 @@ page 6181 "E-Document Purchase Draft"
                     begin
                         UpdateTotal();
                         EDocumentPurchaseHeader.Modify();
+                        GlobalEDocumentNotification.RefreshAndShowSubTotalMismatchAfterHeaderEdit(EDocumentPurchaseHeader);
                         CurrPage.Update();
                     end;
                 }
@@ -266,6 +267,7 @@ page 6181 "E-Document Purchase Draft"
                     trigger OnValidate()
                     begin
                         EDocumentPurchaseHeader.Modify();
+                        GlobalEDocumentNotification.RefreshAndShowSubTotalMismatchAfterHeaderEdit(EDocumentPurchaseHeader);
                         CurrPage.Update();
                     end;
                 }
@@ -509,7 +511,6 @@ page 6181 "E-Document Purchase Draft"
     var
         EDocumentDataStorage: Record "E-Doc. Data Storage";
         PurchasesPayablesSetup: Record "Purchases & Payables Setup";
-        EDocumentNotification: Codeunit "E-Document Notification";
         EDocPOMatching: Codeunit "E-Doc. PO Matching";
         MatchesRemovedMsg: Label 'This e-document was matched to purchase order lines, but the matches are no longer consistent with the current data. The matches have been removed';
     begin
@@ -528,7 +529,7 @@ page 6181 "E-Document Purchase Draft"
         HasErrors := false;
         PageEditable := IsEditable();
         IsCreditMemo := Rec."Document Type" = Enum::"E-Document Type"::"Purchase Credit Memo";
-        EDocumentNotification.SendPurchaseDocumentDraftNotifications(Rec."Entry No");
+        GlobalEDocumentNotification.RefreshAndShowPendingDraftNotifications(Rec."Entry No");
         if PurchasesPayablesSetup.Get() then
             ApplyVATDiffEnabled := PurchasesPayablesSetup."Apply VAT Diff. For Purch EDoc";
 
@@ -779,6 +780,7 @@ page 6181 "E-Document Purchase Draft"
         EDocumentPurchaseHeader: Record "E-Document Purchase Header";
         EDocumentServiceStatus: Record "E-Document Service Status";
         EDocumentErrorHelper: Codeunit "E-Document Error Helper";
+        GlobalEDocumentNotification: Codeunit "E-Document Notification";
         EDocumentProcessing: Codeunit "E-Document Processing";
         FeatureTelemetry: Codeunit "Feature Telemetry";
         GlobalEDocumentHelper: Codeunit "E-Document Helper";