Skip to content

[master] Transfer Order header deletion blocked by reserved quantity — inconsistent with line deletion and all other document types #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neeleshsinghal wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[master] Transfer Order header deletion blocked by reserved quantity — inconsistent with line deletion and all other document types #9705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b5a91e
Fix and automation
neeleshsinghal Jul 23, 2026
f2dfe08
Invoke-MiApp
neeleshsinghal Jul 23, 2026
261570e
Potential fix for pull request finding
neeleshsinghal Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Layers/IT/BaseApp/Inventory/Transfer/TransferLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,13 +1400,15 @@ table 5741 "Transfer Line"

TestField("Quantity Shipped", "Quantity Received");
TestField("Qty. Shipped (Base)", "Qty. Received (Base)");
CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

OnDeleteOnBeforeDeleteRelatedData(Rec);

TransferLineReserve.DeleteLine(Rec);

CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

WhseValidateSourceLine.TransLineDelete(Rec);

ItemChargeAssgntPurch.SetCurrentKey(
Expand Down
8 changes: 5 additions & 3 deletions src/Layers/NA/BaseApp/Inventory/Transfer/TransferLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,13 +1081,15 @@ table 5741 "Transfer Line"

TestField("Quantity Shipped", "Quantity Received");
TestField("Qty. Shipped (Base)", "Qty. Received (Base)");
CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

OnDeleteOnBeforeDeleteRelatedData(Rec);

TransferLineReserve.DeleteLine(Rec);

CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

WhseValidateSourceLine.TransLineDelete(Rec);

ItemChargeAssgntPurch.SetCurrentKey(
Expand Down
8 changes: 5 additions & 3 deletions src/Layers/RU/BaseApp/Inventory/Transfer/TransferLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,13 +1075,15 @@ table 5741 "Transfer Line"

TestField("Quantity Shipped", "Quantity Received");
TestField("Qty. Shipped (Base)", "Qty. Received (Base)");
CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

OnDeleteOnBeforeDeleteRelatedData(Rec);

TransferLineReserve.DeleteLine(Rec);

CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

WhseValidateSourceLine.TransLineDelete(Rec);

ItemChargeAssgntPurch.SetCurrentKey(
Expand Down
8 changes: 5 additions & 3 deletions src/Layers/W1/BaseApp/Inventory/Transfer/TransferLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,13 +1071,15 @@ table 5741 "Transfer Line"

TestField("Quantity Shipped", "Quantity Received");
TestField("Qty. Shipped (Base)", "Qty. Received (Base)");
CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

OnDeleteOnBeforeDeleteRelatedData(Rec);

TransferLineReserve.DeleteLine(Rec);

CalcFields("Reserved Qty. Inbnd. (Base)", "Reserved Qty. Outbnd. (Base)");
TestField("Reserved Qty. Inbnd. (Base)", 0);
TestField("Reserved Qty. Outbnd. (Base)", 0);

WhseValidateSourceLine.TransLineDelete(Rec);

ItemChargeAssgntPurch.SetCurrentKey(
Expand Down
126 changes: 113 additions & 13 deletions src/Layers/W1/Tests/SCM/SCMTransferReservation.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,33 +9,35 @@ codeunit 137269 "SCM Transfer Reservation"
end;

var
Assert: Codeunit Assert;
LibraryERMCountryData: Codeunit "Library - ERM Country Data";
LibraryInventory: Codeunit "Library - Inventory";
LibraryWarehouse: Codeunit "Library - Warehouse";
LibraryItemTracking: Codeunit "Library - Item Tracking";
LibraryJob: Codeunit "Library - Job";
LibraryManufacturing: Codeunit "Library - Manufacturing";
LibraryPlanning: Codeunit "Library - Planning";
LibraryPurchase: Codeunit "Library - Purchase";
LibraryRandom: Codeunit "Library - Random";
LibrarySales: Codeunit "Library - Sales";
LibraryService: Codeunit "Library - Service";
LibraryJob: Codeunit "Library - Job";
LibraryItemTracking: Codeunit "Library - Item Tracking";
LibraryPlanning: Codeunit "Library - Planning";
LibraryManufacturing: Codeunit "Library - Manufacturing";
LibraryVariableStorage: Codeunit "Library - Variable Storage";
LibrarySetupStorage: Codeunit "Library - Setup Storage";
LibraryRandom: Codeunit "Library - Random";
LibraryUtility: Codeunit "Library - Utility";
Assert: Codeunit Assert;
LibraryTestInitialize: Codeunit "Library - Test Initialize";
LibraryUtility: Codeunit "Library - Utility";
LibraryVariableStorage: Codeunit "Library - Variable Storage";
LibraryWarehouse: Codeunit "Library - Warehouse";
isInitialized: Boolean;
ReservationEntryShipmentDateIncorrectErr: Label 'Reservation Entry Shipment Date is incorrect.';
Direction: Option Outbound,Inbound;
ItemTrackingOption: Option AssignLotNo,SelectEntries,ChangeLotQty,AssignSerialNos;
CounterOfConfirms: Integer;
DummyQst: Label 'Dummy Dialog Question?';
ConfirmDialogOccursErr: Label 'Confirm Dialog occurs.';
DummyQst: Label 'Dummy Dialog Question?';
ExpectedDateConfclictErr: Label 'The change leads to a date conflict with existing reservations';
UnexpectedErr: Label 'Unexpected Error occured.';
ReservEntryQtyIncorrectErr: Label 'Reservation Entry Quantity is different than expected.';
ReservationEntryShipmentDateIncorrectErr: Label 'Reservation Entry Shipment Date is incorrect.';
ReservationFromStockErr: Label 'Reservation from Stock must be %1 in %2.', Comment = '%1= Field Value, %2 =Table Caption.';
ReservedQtyExpectedErr: Label 'Reserved Qty. Outbnd. (Base) is expected to be non-zero before deletion.';
ReservEntryQtyIncorrectErr: Label 'Reservation Entry Quantity is different than expected.';
TransferHeaderNotDeletedErr: Label 'Transfer Header should have been deleted.';
UnexpectedErr: Label 'Unexpected Error occured.';
Comment thread
neeleshsinghal marked this conversation as resolved.

[Test]
[Scope('OnPrem')]
Expand Down Expand Up @@ -2078,6 +2080,104 @@ codeunit 137269 "SCM Transfer Reservation"
Assert.RecordIsNotEmpty(ReservationEntry);
end;

[Test]
procedure DeleteTransferHeaderWithReservedOutboundLine()
var
ReservationEntry: Record "Reservation Entry";
TransferHeader: Record "Transfer Header";
TransferLine: Record "Transfer Line";
ItemNo: Code[20];
begin
// [SCENARIO 641400] Deleting a Transfer Order header that has a reserved line succeeds and clears the reservation.
Initialize();

// [GIVEN] A released Transfer Order with one line reserved outbound from inventory.
CreateTransferOrderQtyOneReservedOutbound(TransferHeader, TransferLine);
Comment thread
neeleshsinghal marked this conversation as resolved.
ItemNo := TransferLine."Item No.";

// [GIVEN] The reserved outbound quantity on the line is non-zero.
TransferLine.CalcFields("Reserved Qty. Outbnd. (Base)");
Assert.AreNotEqual(0, TransferLine."Reserved Qty. Outbnd. (Base)", ReservedQtyExpectedErr);

// [WHEN] Deleting the Transfer Order header.
TransferHeader.Delete(true);

// [THEN] The header and its line are deleted without error.
Assert.IsFalse(TransferHeader.Get(TransferHeader."No."), TransferHeaderNotDeletedErr);
TransferLine.SetRange("Document No.", TransferHeader."No.");
Assert.RecordIsEmpty(TransferLine);

// [THEN] No reservation entries remain for the item.
ReservationEntry.SetRange("Item No.", ItemNo);
Assert.RecordIsEmpty(ReservationEntry);
end;

[Test]
procedure DeleteReservedOutboundTransferLine()
var
ReservationEntry: Record "Reservation Entry";
TransferLine: Record "Transfer Line";
DocumentNo: Code[20];
ItemNo: Code[20];
begin
// [SCENARIO 641400] Deleting an individual reserved Transfer Line succeeds and clears the reservation, consistent with header deletion.
Initialize();

// [GIVEN] A Transfer Order with one line reserved outbound from inventory.
CreateTransferLineQtyOneReservedOutbound(TransferLine);
ItemNo := TransferLine."Item No.";
DocumentNo := TransferLine."Document No.";

// [GIVEN] The reserved outbound quantity on the line is non-zero.
TransferLine.CalcFields("Reserved Qty. Outbnd. (Base)");
Assert.AreNotEqual(0, TransferLine."Reserved Qty. Outbnd. (Base)", ReservedQtyExpectedErr);

// [WHEN] Deleting the Transfer Line.
TransferLine.Delete(true);

// [THEN] The line is deleted without error.
TransferLine.SetRange("Document No.", DocumentNo);
Assert.RecordIsEmpty(TransferLine);

// [THEN] No reservation entries remain for the item.
ReservationEntry.SetRange("Item No.", ItemNo);
Assert.RecordIsEmpty(ReservationEntry);
end;

[Test]
procedure DeleteTransferHeaderAndLineWithReservationAreConsistent()
var
TransferHeaderForHeaderDelete: Record "Transfer Header";
TransferHeaderForLineDelete: Record "Transfer Header";
TransferLineForHeaderDelete: Record "Transfer Line";
TransferLineForLineDelete: Record "Transfer Line";
begin
// [SCENARIO 641400] Deleting a reserved Transfer Line and deleting the Transfer Order header both succeed, so the two paths behave consistently.
Initialize();

// [GIVEN] A reserved Transfer Order whose line will be deleted directly.
CreateTransferOrderQtyOneReservedOutbound(TransferHeaderForLineDelete, TransferLineForLineDelete);

// [GIVEN] Another reserved Transfer Order whose header will be deleted.
CreateTransferOrderQtyOneReservedOutbound(TransferHeaderForHeaderDelete, TransferLineForHeaderDelete);

// [WHEN] Deleting the line directly.
TransferLineForLineDelete.Delete(true);

// [THEN] The line is gone.
TransferLineForLineDelete.SetRange("Document No.", TransferHeaderForLineDelete."No.");
Assert.RecordIsEmpty(TransferLineForLineDelete);

// [WHEN] Deleting the header of the other order.
TransferHeaderForHeaderDelete.Delete(true);

// [THEN] The header and its line are gone as well.
Assert.IsFalse(
TransferHeaderForHeaderDelete.Get(TransferHeaderForHeaderDelete."No."), TransferHeaderNotDeletedErr);
TransferLineForHeaderDelete.SetRange("Document No.", TransferHeaderForHeaderDelete."No.");
Assert.RecordIsEmpty(TransferLineForHeaderDelete);
end;

local procedure Initialize()
begin
LibraryTestInitialize.OnTestInitialize(CODEUNIT::"SCM Transfer Reservation");
Expand Down
Loading