Skip to content

[Master] [Repair Item] Team Member unable to copy sales quotation when lines are associated to assembly - #9644

Open
Shikhverma wants to merge 6 commits into
mainfrom
bugs/Bug-630947-Master-TeamMemberUnableToCopySaleQuoteWhenAssemblyItemUsed
Open

[Master] [Repair Item] Team Member unable to copy sales quotation when lines are associated to assembly#9644
Shikhverma wants to merge 6 commits into
mainfrom
bugs/Bug-630947-Master-TeamMemberUnableToCopySaleQuoteWhenAssemblyItemUsed

Conversation

@Shikhverma

@Shikhverma Shikhverma commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Bug 630947: [ALL-E] [Repair Item] Team Member unable to copy sales quotation when lines are associated to assembly

Fixes AB#630947

@github-actions github-actions Bot added the Integration GitHub request for Integration area label Jul 21, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 21, 2026
@Shikhverma Shikhverma added the SCM GitHub request for SCM area label Jul 22, 2026
@github-actions github-actions Bot removed the SCM GitHub request for SCM area label Jul 22, 2026
@Shikhverma Shikhverma added the SCM GitHub request for SCM area label Jul 22, 2026
@github-actions github-actions Bot removed the SCM GitHub request for SCM area label Jul 22, 2026
OnAfterCopySalesDocForCrMemoCancelling(FromDocNo, ToSalesHeader, IncludeHeader, RecalculateLines, MoveNegLines, CreateToHeader, HideDialog, ExactCostRevMandatory, ApplyFully, SkipTestCreditLimit, SkipCopyFromDescription);
end;

[InherentPermissions(PermissionObjectType::TableData, Database::"Assembly Header", 'RIMD', InherentPermissionsScope::Both)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all RIMD on these objects?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all RIMD on these objects?
Changes done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addressed? Fx, why do we need RIMD on Assembly Header and Assembly Line in this function?

…Bug-630947-Master-TeamMemberUnableToCopySaleQuoteWhenAssemblyItemUsed
@Shikhverma
Shikhverma requested a review from ChethanT July 24, 2026 04:14
@Shikhverma Shikhverma closed this Jul 28, 2026
@Shikhverma Shikhverma reopened this Jul 28, 2026
@Shikhverma Shikhverma closed this Jul 28, 2026
@Shikhverma Shikhverma reopened this Jul 28, 2026
@microsoft microsoft deleted a comment from github-actions Bot Jul 28, 2026
@Shikhverma Shikhverma added the SCM GitHub request for SCM area label Jul 28, 2026
@github-actions github-actions Bot removed the SCM GitHub request for SCM area label Jul 28, 2026
@Shikhverma Shikhverma closed this Jul 28, 2026
@Shikhverma Shikhverma reopened this Jul 28, 2026
Comment thread src/Layers/W1/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al Outdated
@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟠\ High\ Severity\ —\ Security}$

In all six layer copies of codeunit 6620 "Copy Document Mgt.", the new attribute block on procedure CopySalesShptLinesToDoc grants "Assembly Header"/"Assembly Line"/"Assemble-to-Order Link" ('RIMD') and "Posted Assembly Header"/"Posted Assembly Line" ('R'), but the procedure body directly calls FromSalesShptLine.AsmToShipmentExists(PostedAssemblyHeader), which reads table "Posted Assemble-to-Order Link" (via PostedAssembleToOrderLink.AsmExistsForPostedShipmentLine). No attribute in this procedure grants read access to "Posted Assemble-to-Order Link", so a caller relying on this attribute for authorization can still hit a runtime permission error when copying posted shipment lines that have an assemble-to-order link.

Knowledge:

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.18.4

@Shikhverma Shikhverma added the SCM GitHub request for SCM area label Jul 31, 2026
@github-actions github-actions Bot removed the SCM GitHub request for SCM area label Jul 31, 2026
Comment thread src/Layers/W1/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration GitHub request for Integration area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants