fix(rand): return errors for invalid random string inputs#360
Open
hazelmayank wants to merge 1 commit intomicrocks:masterfrom
Open
fix(rand): return errors for invalid random string inputs#360hazelmayank wants to merge 1 commit intomicrocks:masterfrom
hazelmayank wants to merge 1 commit intomicrocks:masterfrom
Conversation
Signed-off-by: hazelmayank <mayankjeefinal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two panic cases in
pkg/util/rand.The helper functions
StringandStringFromCharsetreturn(string, error), but a couple of invalid inputs were causing the process to panic instead of returning an error.The panic cases were:
StringFromCharset(1, "")panicked becausecrypto/rand.Intwas called with a max value of0String(-1)panicked because it tried to allocate a byte slice with a negative lengthThis PR adds input validation before allocation and random index generation, so invalid inputs now return clear errors instead of crashing.
Fixes #359
Valid behavior is preserved: