Skip to content

refactor a parameter for SetCellUsing and SetPropertyUsing#213

Open
andywu188 wants to merge 5 commits into
mganss:masterfrom
andywu188:original
Open

refactor a parameter for SetCellUsing and SetPropertyUsing#213
andywu188 wants to merge 5 commits into
mganss:masterfrom
andywu188:original

Conversation

@andywu188

Copy link
Copy Markdown
Contributor
  1. Solve the problem that SetCellUsing and SetPropertyUsing parameters are not named and ambiguous.
  2. Improved support for parameters that can perform multiple property value calculations

@codecov

codecov Bot commented Aug 26, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (1ecae95) to head (3225253).
⚠️ Report is 54 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   94.29%   95.27%   +0.97%     
==========================================
  Files          11       13       +2     
  Lines        1384     1417      +33     
  Branches      203      203              
==========================================
+ Hits         1305     1350      +45     
+ Misses         51       39      -12     
  Partials       28       28              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mganss

mganss commented Aug 26, 2022

Copy link
Copy Markdown
Owner

Thanks. There are some uncovered lines still, though.

@andywu188

Copy link
Copy Markdown
Contributor Author

already updated

@andywu188

Copy link
Copy Markdown
Contributor Author

I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete.

@mganss

mganss commented Aug 26, 2022

Copy link
Copy Markdown
Owner

I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete.

Can you add this to the PR?

@andywu188

Copy link
Copy Markdown
Contributor Author

already updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants