Fixed versions - #56
Closed
ArturDevico wants to merge 2 commits into
Closed
Conversation
mchardysam
pushed a commit
that referenced
this pull request
Jul 31, 2026
The old stub was generated with protoc < 3.19 and built its descriptors via _descriptor.FieldDescriptor(). protobuf 4 and up rejects that, so importing binance_chain.messages or binance_chain.http died with "TypeError: Descriptors cannot be created directly". requirements.txt asked for protobuf>=3.6.1, so a fresh install pulled protobuf 7 and the package was unusable on install. Only the generated file was ever committed, no .proto source, so I recovered the schema from the descriptor embedded in the old stub and checked it in as dex.proto. The regenerated stub serialises to a byte-identical FileDescriptorProto, so the wire format and signing are unchanged. test_messages.py asserts exact signed transaction hex and still passes. Generated with protoc 4.25 on purpose. protoc 7 output adds a runtime version gate that would force everyone onto protobuf 7, while the 4.25 builder output works on 4.x through 7.x. Also adds ujson to requirements.txt. It was already in setup.py install_requires but missing here, so installing from requirements.txt alone gave "No module named 'ujson'". Thanks @ArturDevico for flagging that in #56.
Owner
|
@ArturDevico thanks for this, the I didn't take the Closing this one, thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated versions to fix poetry issue