Skip to content

Resolve iOS issue w/ new two-tiered header - #3383

Merged
lilybarrett merged 5 commits into
mainfrom
lb/troubleshoot-ios-header-bug
Aug 11, 2026
Merged

Resolve iOS issue w/ new two-tiered header#3383
lilybarrett merged 5 commits into
mainfrom
lb/troubleshoot-ios-header-bug

Conversation

@lilybarrett

@lilybarrett lilybarrett commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

This solves an iOS bug as part of https://app.asana.com/1/15492006741476/project/1213994587940653/task/1216860386844707?focus=true

Scope

The bug was tricky to troubleshoot since it did not appear when emulating iOS devices using browser dev tools -- only when using an actual iOS device. Android was unaffected.

Asana Ticket:
https://app.asana.com/1/15492006741476/project/1213994587940653/task/1216860386844707?focus=true

Implementation

  • This was the result (in part) of trying to impose desktop-appropriate behaviors while on mobile.
  • This PR fixes that ^ and also renames some variables used in the header logic/styling.

Screenshots

How to test

To repro the bug:

  • Navigate to Dotcom prod on a mobile device and enable the flag
  • Click on the languages menu
  • This will 1) not actually show the languages menu, and 2) freeze the page

To test the fix:

  • Navigate to Dotcom dev-blue on a mobile device and enable the flag
  • Click on the languages menu, the bottom menu, etc. Everything should work as expected. Please let me know if I've missed anything glaring!

Comment thread assets/css/_global-navigation.scss
Comment thread assets/ts/app/global-navigation.ts
Comment thread assets/ts/app/global-navigation.ts
Comment thread assets/ts/app/global-navigation.ts
Comment thread assets/ts/app/global-navigation.ts
@lilybarrett
lilybarrett marked this pull request as ready for review August 5, 2026 17:35
@lilybarrett
lilybarrett requested a review from a team as a code owner August 5, 2026 17:35
@lilybarrett
lilybarrett requested a review from joshlarson August 5, 2026 17:35
@lilybarrett lilybarrett changed the title See if this fixes things on staging Resolve iOS issue w/ new two-tiered header Aug 5, 2026
@lilybarrett
lilybarrett requested a review from thecristen August 5, 2026 17:37
thecristen

This comment was marked as resolved.

@lilybarrett

This comment was marked as resolved.

@thecristen thecristen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fixed to me now!!! Could you please clean up the commented out CSS and HTML bits before merging -- thanks! 🎉

@github-actions github-actions Bot removed the dev-blue Deploy to dev-blue label Aug 11, 2026
Lily Barrett added 4 commits August 11, 2026 17:47
Playing around with more logic

Another tweak to test on mobile
Run Prettier

Fix TS error

More renaming
See if this keeps the Languages button from disappearing on iOS device

Temporary change for testing

Try this to see if it keeps toggle from disappearing on iOS

More testing
@lilybarrett
lilybarrett force-pushed the lb/troubleshoot-ios-header-bug branch from dc49e26 to e84cf0d Compare August 11, 2026 21:47
@lilybarrett
lilybarrett merged commit 7d7a9f9 into main Aug 11, 2026
20 checks passed
@lilybarrett
lilybarrett deleted the lb/troubleshoot-ios-header-bug branch August 11, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants