Avoid ValueError on Unicode-numeric start/colspan attributes#269
Open
santhreal wants to merge 1 commit into
Open
Avoid ValueError on Unicode-numeric start/colspan attributes#269santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
`<ol start="²">` and `<td colspan="②">` raised ValueError from the public markdownify() API. The guards used str.isnumeric()/str.isdigit(), which accept Unicode numerics (superscripts, fractions, CJK, roman, circled digits) that int() then rejects. Use str.isdecimal(), which accepts exactly what int() parses, so these values fall back to the default (start=1, colspan=1) as browsers do, matching the existing behavior for "foo"/"1.5".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdownify('<ol start="²"><li>a</li></ol>')raisesValueError: invalid literal for int() with base 10: '²'. The same happens for acolspanattribute, e.g.<td colspan="²">or<td colspan="②">.The list-start guard uses
str.isnumeric()and the colspan guards usestr.isdigit(). Both returnTruefor Unicode numeric characters (superscripts, fractions, CJK numerals, roman numerals, circled digits) that the followingint()then rejects, so the whole conversion crashes on valid HTML where a browser would just fall back to the default.str.isdecimal()isTruefor exactly the charactersint()accepts (verified across the full Unicode range), so switching the guards to it removes the crash while keeping every currently-working value identical, including the existing"foo"/"-1"/"1.5"/"undefined"fallbacks.Repro:
Extended
test_olandtest_tablewith the Unicode-attribute cases.