Escape pipe characters in table cells#267
Open
gaoflow wants to merge 1 commit into
Open
Conversation
A literal '|' in td/th content is parsed by GFM as a column delimiter, adding spurious columns and corrupting the table. Escape it as '\|' unless it is already escaped (escape_misc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cell content containing a literal
|is emitted unescaped, so the pipe is parsed as a column delimiter and the table gains spurious columns:(three data cells under a two-column header, and everything after the stray pipe lands in the wrong column)
This escapes
|as\|inconvert_td/convert_th, skipping pipes thatescape_misc=Truehas already escaped. It's done in the cell converters rather than inescape()so pipes inside code spans are covered too: GFM splits rows into cells before inline parsing, so`1|2`also breaks the row and has to be written as`1\|2`(checked against cmark-gfm via pandoc, which escapes cell pipes the same way).