Revert "fix: specialize server-prepared parameter types at execution … - #27485
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…atrixorigin#27316)" This reverts commit 0e5db4c.
cc49390 to
e028099
Compare
aunjgr
left a comment
There was a problem hiding this comment.
Reviewed exact head b561897. The revert removes the per-COM_STMT_EXECUTE specialization/deep copy, while the independent generic plan-clone fields and tests remain intact (including OnDuplicateAction, SEND/RECV message headers, ScanSnapshot, and CREATE AS SELECT cloning). No blocking issue found.
XuPeng-SH
left a comment
There was a problem hiding this comment.
Reviewed exact head b561897.
The new commit closes my prior blocker: the revert is now scoped to the per-COM_STMT_EXECUTE parameter-specialization/deep-copy traversal that caused the TPCC regression, while generic DeepCopyNode/DeepCopyQuery/DeepCopyDataDefinition correctness remains intact. OnDuplicateAction, SEND/RECV headers, snapshots, CTAS execution fields, and independent YEAR literal materialization are retained with ownership-focused tests.
Focused plan, colexec, and frontend prepared-statement tests pass locally, and CI is green. No remaining blocking issue found.
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 1 minute 12 seconds in the queue, with no time running CI. Waiting for
All conditions
ReasonPull request #27485 has been dequeued Pull request from fork cannot be queued. This pull request comes from a fork, and Mergify needs the author's permission to update its branch.
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Tick the box to put this pull request back in the merge queue (same as
|
What type of PR is this?
Which issue(s) this PR fixes:
issue #27477
What this PR does / why we need it:
导致回归性能下降 。 reverts commit 0e5db4c.