fix: preserve user-defined fileservice cache fields - #607
Merged
loveRhythm1990 merged 1 commit intoAug 21, 2026
Merged
Conversation
loveRhythm1990
marked this pull request as ready for review
August 21, 2026 06:54
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Pull request overview
Fixes deep merging of user-defined fileservice cache settings while preserving operator precedence.
Changes:
- Normalizes generated cache tables to
map[string]interface{}. - Adds DN regression coverage using decoded TOML.
- Updates unit expectations and ignores local documentation drafts.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.gitignore |
Ignores local documentation directories. |
pkg/controllers/common/fileservice.go |
Normalizes generated cache maps. |
pkg/controllers/common/fileservice_test.go |
Updates expected cache types. |
pkg/controllers/dnset/resource_test.go |
Verifies user fields survive controller merging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ariznawlll
approved these changes
Aug 21, 2026
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map[string]interface{}at the sourcedocs/troubleshooting/anddocs/draftdirectoriesTesting
go test ./api/...KUBEBUILDER_ASSETS="/Users/lr90/Library/Application Support/io.kubebuilder.envtest/k8s/1.24.1-darwin-amd64" CGO_ENABLED=0 go test ./pkg/...CGO_ENABLED=0 go vet ./api/... ./pkg/...make check-licensegit diff --checkFixes #602