[pull] develop from isaac-sim:develop - #57
Merged
Merged
Conversation
Bumped packages: - isaaclab: 27.0.0 → 27.0.1 - isaaclab_ov: 3.3.0 → 3.3.1 - isaaclab_rl: 1.1.1 → 1.2.0 - isaaclab_tasks: 21.0.2 → 21.0.3
#7960) ## Description Part of #7403 `_resolve_visualizer_cfgs` compared the raw, possibly-deprecated-alias CLI string (e.g. `"newton"`) against each resolved config's canonical `visualizer_type` (e.g. `"newton_gl"`). Requesting `--visualizer newton` succeeded in creating a `NewtonGLVisualizerCfg`, but the alias itself was never present in the set of canonical resolved types, so it was reported as missing and `RuntimeError: Explicitly requested visualizer(s) ['newton'] could not be configured` fired anyway — even though the visualizer resolved and worked fine. Every CLI-requested-vs-resolved comparison in `_resolve_visualizer_cfgs` now routes through the existing `_VISUALIZER_ALIASES` mapping. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the contribution guidelines - [x] I have run the `pre-commit` checks with `./isaaclab.sh --format` - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective - [x] I have added a changelog fragment under `source/isaaclab/changelog.d/` ## Test plan - `uv run --extra test --extra rerun --extra viser pytest source/isaaclab/test/sim/test_simulation_context_visualizers.py -q` — 45 passed, including new coverage for the deprecated-alias-alone case and the branch that merges CLI selection with pre-existing `cfg.visualizer_cfgs` entries (a customized existing config selected via its alias is returned as-is; an existing config alongside an additional unresolvable type still raises for just the failure) - `uv run --extra test --extra rerun --extra viser pytest source/isaaclab/test/visualizers/test_visualizer.py source/isaaclab/test/app/test_app_launcher_argv.py -q` — 35 passed - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop`
# Description Small perf optimization to cache the keys rather than create them at the runtime at each invocation. Fixes # (issue) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (existing functionality will not work without user modification) - Documentation update ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist Docker and GPU tests run on demand. Push the commits you want tested, then comment `run-ci` on the pull request. - [ ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )