chore: fix govet reflect.Ptr lint findings in config command#195
Open
iamlasse wants to merge 1 commit into
Open
chore: fix govet reflect.Ptr lint findings in config command#195iamlasse wants to merge 1 commit into
iamlasse wants to merge 1 commit into
Conversation
Replace deprecated reflect.Ptr with reflect.Pointer to resolve govet inline findings. Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal-scope lint fix.
golangci-lint run ./...onorigin/mainreported 2 govetinlinefindings incmd/nightshift/commands/config.go, both flagging the deprecatedreflect.Ptr. Replaced both occurrences with the modernreflect.Pointeralias (identical behavior;reflect.Ptris a deprecated alias kept only for compatibility).After the change:
golangci-lintreports 0 issues,go build ./...andmake testpass.Scope note
This PR addresses exactly the findings present on
origin/main. The plan mentioned 2 additionalerrcheckfindings incommit.go(fmt.Fprintln(os.Stdout, normalized)), but that file does not exist onorigin/main— it is introduced by a separate, unmerged feature commit (feat(commits): add Conventional Commits message normalizer, c26c5fd). Bundling that feature here would violate the minimal-scope / no-behavior-changes intent of this lint-fix task, so it is excluded.Changes
cmd/nightshift/commands/config.go:reflect.Ptr→reflect.Pointer(2 sites)Nightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift
Automated by nightshift