chore(lint): reduce 'make lint' to zero findings#190
Open
iamlasse wants to merge 1 commit into
Open
Conversation
Apply golangci-lint autofixes: replace deprecated reflect.Ptr with reflect.Pointer (govet inline) and normalize import grouping via goimports. No behavioral changes; make lint now passes with 0 issues. Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces
make lint(golangci-lint run) to 0 issues on the nightshift module via an autofix-first approach. No behavioral changes.What changed
reflect.Ptrconstant withreflect.Pointer(Go 1.18+ alias) incmd/nightshift/commands/config.go(2 occurrences).-local github.com/marcus/nightshift) across the touched command/internal packages.Categories of lint issues fixed
inline) — 2 findings inconfig.go.goimports/gofmt.Verification
make lint→0 issues(exit 0)go build ./...→ cleango vet ./...→ cleango test ./...→ all packages pass