Skip to content

Fix why the README avoids curl in the PowerShell install snippet #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattpodwysocki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix why the README avoids curl in the PowerShell install snippet #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,14 @@ Expand-Archive $artifact.file -DestinationPath .
```

`Invoke-WebRequest` and `Get-FileHash` rather than `curl` and `sha256sum`:
the first is an alias for something else in Windows PowerShell and neither of
the others is guaranteed to be present.
Windows PowerShell 5.1 — the edition that ships with Windows, `powershell.exe`
— aliases `curl` to `Invoke-WebRequest`, whose flags are nothing like real
curl's, so the commands above would silently run the wrong tool there even
though `curl.exe` itself has shipped in `System32` since Windows 10 1803.
PowerShell 7 (`pwsh`) dropped that alias, so `curl` there is the real thing —
but 5.1 is still what a plain "Windows PowerShell" shortcut opens on a
default install. `sha256sum` has the simpler problem: it isn't shipped at
all outside WSL or Git Bash.

Use `latest` in place of the version for whatever is current. Each archive
holds one file, the `mapbox` executable, so there is no directory to step
Expand Down
Loading