e2e: wait for multicast-group convergence in doublezero status check#3908
Merged
Conversation
39d9731 to
6e0cfdc
Compare
nikw9944
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
doublezero statusassertion incheckMulticastPostConnectin a polling loop so it waits for multicast-group membership to converge instead of taking a single, non-retried snapshot. This fixes a test-side race where the second group (mg02) subscription had not yet propagated into the client daemon's local status view, producingS:mg01instead of the expectedS:mg01,S:mg02and failing the CLI-table diff.doublezero_multicast_group_listcheck is intentionally left as a single snapshot because it reads onchain state, which is already consistent.-(want), +(got)diff (or the last exec error) are still printed, so a real failure is not opaque.Testing Verification
go vet -tags e2e ./e2epasses; the package compiles and isgofmt-clean.TestE2E_Multicastruns (each spins up multiple cEOS containers), so it cannot be deterministically reproduced in a single run. The change converts the single-snapshot assertion that lost the race into the sameEventually-poll idiom already proven for the route/PIM convergence checks in this file, which read the same asynchronously-populated daemon state.