Repository navigation
Fix BONanza chat number formatting edge case - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatChatNumbersWithSpaces()so comma-separated giveaway number lists are never collapsed into a fake thousands-grouped valueSch2021triggering unrelated number formatting1000,1,000,1 000,1'000,1’000) normalized to spaces28, 36, 52, 83, 89->28, 365 283, 89) and the ambiguous28, 365list caseRoot cause
The old formatter first woke up on any four consecutive digits anywhere in the message (including
Sch2021), then used a permissive regex that treated commas and whitespace as part of one numeric token. That allowed36, 52, 83to be collapsed to365283and re-formatted as365 283.Expected behavior
Only a single lexical numeric token is formatted at a time. Comma thousands grouping requires no following space, which keeps normal giveaway list syntax (
28, 365, ...) unambiguous.