dr_wav: Reject AIFF/AIFC COMM chunks with unsupported bit depths. - #333
Closed
timblechmann wants to merge 1 commit into
Closed
dr_wav: Reject AIFF/AIFC COMM chunks with unsupported bit depths.#333timblechmann wants to merge 1 commit into
timblechmann wants to merge 1 commit into
Conversation
A crafted AIFC COMM chunk can declare a bitsPerSample value that is a multiple of 8 but doesn't correspond to a supported sample byte width (e.g. 40 bits = 5 bytes per sample). This previously went unvalidated and was only discovered deep in the decode path, in drwav__bswap_samples()'s big-endian conversion, which hits `DRWAV_ASSERT(DRWAV_FALSE)` on unsupported byte widths and aborts the process. Validate bitsPerSample right after AIFF's byte-padding step and reject the file (return DRWAV_FALSE) if it doesn't resolve to one of the supported byte widths (1, 2, 3, 4, 8). Found by OSS-Fuzz.
Contributor
Author
|
minimized reproducer: |
Owner
|
This is invalid. There is a function called |
mackron
added a commit
that referenced
this pull request
Aug 31, 2026
Owner
|
This should be fixed in the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crafted AIFC COMM chunk can declare a bitsPerSample value that is a multiple of 8 but doesn't correspond to a supported sample byte width (e.g. 40 bits = 5 bytes per sample). This previously went unvalidated and was only discovered deep in the decode path, in drwav__bswap_samples()'s big-endian conversion, which hits
DRWAV_ASSERT(DRWAV_FALSE)on unsupported byte widths and aborts the process. Validate bitsPerSample right after AIFF's byte-padding step and reject the file (return DRWAV_FALSE) if it doesn't resolve to one of the supported byte widths (1, 2, 3, 4, 8).Found by OSS-Fuzz.