Skip to content

breaking: Remove Toggle Fix from public API #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KSkwarczynski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

breaking: Remove Toggle Fix from public API #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CIValidations/CovarianceValidations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ void TestPCA(const std::string& label,

PCA->AcceptStep();

PCA->ToggleFixAllParameters();
PCA->SetFixAllParameters();
for (int i = 0; i < PCA->GetPCAHandler()->GetNumberPCAedParameters(); i++) {
outFile << "Param in " << label << " is Fixed: " << i << " = " << PCA->GetPCAHandler()->IsParameterFixedPCA(i) << std::endl;
}
Expand Down Expand Up @@ -222,7 +222,7 @@ void TestAdaptive(std::ostream& outFile,
Adapt->SetParCurrProp(i, Adapt->GetParInit(i));
}
}
Adapt->ToggleFixAllParameters();
Adapt->SetFixAllParameters();
for (int i = 0; i < Adapt->GetNumParams(); i++) {
outFile << "Adapt " << Name <<" is param " << i << " fixed=" << Adapt->IsParameterFixed(i) << std::endl;
}
Expand Down Expand Up @@ -341,7 +341,7 @@ int main(int argc, char *argv[])
for (int i = 0; i < xsec->GetNumParams(); i++) {
outFile << "Is param " << i << " fixed=" << xsec->IsParameterFixed(i) << std::endl;
}
xsec->ToggleFixAllParameters();
xsec->SetFixAllParameters();
for (int i = 0; i < xsec->GetNumParams(); i++) {
outFile << "Is param " << i << " fixed=" << xsec->IsParameterFixed(i) << std::endl;
}
Expand Down
18 changes: 9 additions & 9 deletions CIValidations/TestOutputs/CovarianceOut.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2103,10 +2103,10 @@ Param in PCA_3 is Fixed: 18 = 1
Param in PCA_3 is Fixed: 19 = 1
Param in PCA_3 is Fixed: 20 = 1
Param in PCA_3 is Fixed: 21 = 1
Param in PCA_3 is Fixed: 22 = 0
Param in PCA_3 is Fixed: 23 = 0
Param in PCA_3 is Fixed: 24 = 0
Param in PCA_3 is Fixed: 25 = 0
Param in PCA_3 is Fixed: 22 = 1
Param in PCA_3 is Fixed: 23 = 1
Param in PCA_3 is Fixed: 24 = 1
Param in PCA_3 is Fixed: 25 = 1
PCA_4 Eigen Value 0 = 0.0239541
PCA_4 Eigen Value 1 = 0.0121
PCA_4 Eigen Value 2 = 0.0074135
Expand Down Expand Up @@ -3125,11 +3125,11 @@ Param in PCA_4 is Fixed: 16 = 1
Param in PCA_4 is Fixed: 17 = 1
Param in PCA_4 is Fixed: 18 = 1
Param in PCA_4 is Fixed: 19 = 1
Param in PCA_4 is Fixed: 20 = 0
Param in PCA_4 is Fixed: 21 = 0
Param in PCA_4 is Fixed: 22 = 0
Param in PCA_4 is Fixed: 23 = 0
Param in PCA_4 is Fixed: 24 = 0
Param in PCA_4 is Fixed: 20 = 1
Param in PCA_4 is Fixed: 21 = 1
Param in PCA_4 is Fixed: 22 = 1
Param in PCA_4 is Fixed: 23 = 1
Param in PCA_4 is Fixed: 24 = 1
PCA_5 Eigen Value 0 = 1
PCA_5 Eigen Value 1 = 1
PCA_5 Eigen Value 2 = 1
Expand Down