Wait a second more in tests to help slower architectures#155
Open
hrw wants to merge 2 commits into
Open
Conversation
This could be completely misguided, but it fixes the tests on riscv64 and builds in Fedora koji scratch build. On some slower (riscv64, s390x) architectures there is race window between creating a test server socket and a test client trying to connect to it before its actually ready to accept connections. This is inherent in the current way tests are set up. Try adding an additional 1 second wait on the first select to workaround without re-architecting the thing. Signed-off-by: Yanko Kaneti <yaneti@declera.com> Signed-off-by: Marcin Juszkiewicz <mjuszkiewicz@redhat.com> Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
stream_select() takes three arrays as arguments but $E was given twice. Signed-off-by: Yanko Kaneti <yaneti@declera.com> Signed-off-by: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We build this project for RISC-V 64-bit architecture port of Fedora and build was always failing in tests. First we solved it by dropping one test, and then @yaneti came with the idea of changing test a bit to make it pass.
Is it the right solution? We are not sure.
Is it the working solution? For us, yes.
@remicollet asked us to submit it upstream so we did.