Add token alias for Whisper model loading#1407
Open
bobsummerwill wants to merge 1 commit intom-bain:mainfrom
Open
Add token alias for Whisper model loading#1407bobsummerwill wants to merge 1 commit intom-bain:mainfrom
bobsummerwill wants to merge 1 commit intom-bain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
tokenalias towhisperx.asr.load_model()while preserving the existinguse_auth_tokenargument for backward compatibility.Why
WhisperX has already migrated its pyannote-facing code to
token, but the ASR model-loading surface still exposeduse_auth_token.The remaining internal use still needs to be forwarded to
faster-whisper, whose currentWhisperModelAPI expectsuse_auth_token.This change updates the WhisperX API surface to accept
tokenconsistently without breaking the downstream faster-whisper call.Changes
tokenas the preferred alias inwhisperx.asr.load_model()use_auth_tokenas a legacy alias for backward compatibilityValueErrorif both are passed with conflicting valueswhisperx/transcribe.pyto passtoken=hf_tokenValidation
python3 -m py_compile whisperx/asr.py whisperx/transcribe.pyFixes #1406