[dv] V1 signoff for SPI Device DV block - #699
Open
tchilikov-semify wants to merge 1 commit into
Open
tchilikov-semify wants to merge 1 commit into
tchilikov-semify wants to merge 1 commit into
Conversation
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
August 27, 2026 11:23
7617668 to
73fffe0
Compare
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
September 29, 2026 09:21
73fffe0 to
be6a997
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
One comment from my end.
Comment on lines
+62
to
+63
| | Tests | SIM_SMOKE_TEST_PASSING | Done | `spi_device_flash_and_tpm`: 1/1 passed with Xcelium on September 29, 2026 at commit `55fa175` | | ||
| | Regression | SIM_SMOKE_REGRESSION_SETUP | Done | `smoke` regression in `base_sim_cfg.hjson` selects `spi_device_flash_mode`; the aggregate Mocha config imports the <br/> SPI device simulation config | |
Collaborator
There was a problem hiding this comment.
These two are not the same test. Can you double check whether this is intentional? I would expect them to the same.
Collaborator
Author
There was a problem hiding this comment.
The smoke regression does actually map to spi_device_flash_mode, and not the smoke test from line 62, but this divergence is vendored in from OT. I would also expect that the two smoke testpoints are the same test. How do you propose we handle it?
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
September 30, 2026 10:35
be6a997 to
1210c07
Compare
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
September 30, 2026 13:17
1210c07 to
ba7f0cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to sign off the SPI Device DV to V1
Closes Issue #162