Remove duplicate "fudge" entry from the packages list - #28
Open
jon-proximafusion wants to merge 1 commit into
Open
Remove duplicate "fudge" entry from the packages list#28jon-proximafusion wants to merge 1 commit into
jon-proximafusion wants to merge 1 commit into
Conversation
"fudge" is listed twice in [tool.setuptools] packages. setuptools dedupes the list, so this has no effect on what gets installed, but the repeat is confusing when editing the list. Co-authored-by: shimwell <mail@jshimwell.com> Co-authored-by: jon-proximafusion <jon@proximafusion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"fudge"appears twice in the[tool.setuptools] packageslist, at lines 24 and 30. This removes the second occurrence.Purely cosmetic: setuptools dedupes the list, so nothing about the installed result changes. I verified that rather than assuming it, by building a wheel from
masterand from this branch and comparing them:fudge/fudgeVersion.py(just the git derived version string) and 4 compiled artifacts, which have identical byte sizes and differ only through build paths embedded by the compiler.Also confirmed setuptools reports 33 package entries and 32 unique before, 32 and 32 after.