Warn when ACE average heating numbers are written as zeros - #27
Open
jon-proximafusion wants to merge 1 commit into
Open
Warn when ACE average heating numbers are written as zeros#27jon-proximafusion wants to merge 1 commit into
jon-proximafusion wants to merge 1 commit into
Conversation
The ESZ block's average heating (KERMA) column is unconditionally filled with zeros, and is not recomputed elsewhere. Codes that read heating from this column therefore get a valid ACE file in which heating is silently zero everywhere. Emit a warning at the point the zeros are written, and record the limitation in the module's existing "Issues" docstring. The numeric content of the generated ACE file is unchanged. Co-authored-by: shimwell <mail@jshimwell.com> Co-authored-by: jon-proximafusion <jon@proximafusion.com>
jon-proximafusion
force-pushed
the
warn-on-zero-ace-heating
branch
from
July 31, 2026 13:46
85d0d0d to
de786d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gndsToACE.pyfills the ESZ average heating (KERMA) column with zeros unconditionally, and the value is never recomputed elsewhere. Codes that read heating from that column get a valid ACE file in which heating is zero at every energy, so a heating tally silently returns zero instead of failing.This doesn't calculate the heating numbers (that needs a HEATR equivalent). It just makes the gap visible: a
warnings.warnwhere the zeros are written, plus an entry in the module's existingIssues:docstring. Generated ACE files are numerically unchanged.warnings.warnrather than the module'sprintMessage(verbose > 0, ...)helper, since gating onverbosewould leave the default path silent. Happy to switch that, or to raise instead, if you'd prefer.