fix: pin sanitize-html to 2.17.5 to restore the ens api routes - #795
Merged
Conversation
2.17.7 pulls the ESM-only htmlparser2 12, which crashes Vercel's function runtime at import and 500s every /api/ens-data call. The exact pin stops in-range refreshes from re-landing it (as #788's pnpm update silently did) until the runtime is confirmed >=20.19. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a targeted dependency pin with consistent lockfile updates that directly addresses the reported runtime import failure.
Pull request overview
Pins sanitize-html to a known-good version to restore Next.js ENS API routes that were failing at module import time due to a transitive ESM/runtime incompatibility.
Changes:
- Pin
sanitize-htmldependency from^2.17.7to exact2.17.5inpackage.json. - Update
pnpm-lock.yamlto resolvesanitize-html@2.17.5(andhtmlparser2@10.1.0), removing thehtmlparser2@12/Node engine constraints that were reintroduced by the semver range.
File summaries
| File | Description |
|---|---|
| package.json | Pins sanitize-html to 2.17.5 to prevent semver-range re-resolution to the breaking version. |
| pnpm-lock.yaml | Aligns the lockfile to the pinned version and restores the previous transitive dependency graph. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#788's
pnpm updatesilently re-landed sanitize-html 2.17.7 inside the^2.17.5range — the same htmlparser2-12/ESM break as #777 — so every/api/ens-data*call 500s in production (x-matched-path: /_error: the function dies at import, before the handler's error handling). ENS names, avatars, and search are down.This pins sanitize-html to exactly 2.17.5, restoring the byte-identical resolution (htmlparser2 10.1.0) that production ran before #788. Re-accepts two moderate advisories on 2.17.5 until the Vercel runtime is confirmed on Node ≥ 20.19 — then the pin can be lifted and #784 re-landed.
Verified locally: 363/363 tests, build,
/api/ens-data/[address]200 on the built server.