chore: move every node pin to 24 to match the vercel runtime - #785
Open
rickstaa wants to merge 1 commit into
Open
chore: move every node pin to 24 to match the vercel runtime#785rickstaa wants to merge 1 commit into
rickstaa wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR claims “every” Node pin is aligned to 24, but repo docs/devcontainer still reference Node 22 and should be updated or the PR scope/description corrected.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Aligns the repository’s Node.js version pins with Vercel’s Node 24 runtime to avoid local/CI/runtime mismatches and to unblock follow-up work that assumes Node 24.
Changes:
- Bump
package.jsonengines.nodefrom22.xto24.x. - Update Docker base images from
node:22tonode:24. - Update developer/CI Node pins (
.nvmrc,.tool-versions, and GitHub Actions workflows) to Node 24.
File summaries
| File | Description |
|---|---|
| package.json | Updates engines.node to 24.x so platform/runtime selection follows Node 24. |
| Dockerfile | Switches both build and runtime stages to node:24. |
| .tool-versions | Updates asdf Node version to 24.11.0. |
| .nvmrc | Updates nvm Node major version to 24. |
| .github/workflows/lighthouse-vercel-preview.yml | Runs the Lighthouse preview job on Node 24. |
| .github/workflows/ci.yml | Runs CI (lint/typecheck/tests) on Node 24. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
98
to
101
| "main": "package.json", | ||
| "engines": { | ||
| "node": "22.x" | ||
| "node": "24.x" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vercel project now runs on Node 24, but the repo still pinned 22 (and
.tool-versionseven 20). This aligns every pin:engines,.nvmrc,.tool-versions, both CI workflows, and the Dockerfile.No dependency changes; groundwork for re-landing the sanitize-html bump in #784, which shrinks to just the dependency change once this merges.
Verified under Node 24.11: 121/121 tests, lint and typecheck clean.