support SimulateScenario through FFI to improve testing#1069
Merged
support SimulateScenario through FFI to improve testing#1069
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
Support SimulateScenario through FFI to enhance testing capabilities.
ladvoc
approved these changes
May 9, 2026
ladvoc
approved these changes
May 9, 2026
theomonnom
approved these changes
May 9, 2026
xianshijing-lk
approved these changes
May 9, 2026
Contributor
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
great work. it looks like a solid improvement, thanks for fixing the problems there.
one question and one nit.
| inner.send(ping).await; | ||
| } | ||
| _ = &mut ping_timeout => { | ||
| let _ = emitter.send(SignalEvent::Close("ping timeout".into())); |
Contributor
There was a problem hiding this comment.
This is not an issue with this PR, but simply a question.
When a ping timeout happened, it emits SignalEvent::Close, exits the loop, then closes/removes the stream.
Is this an expected or documented behavior ? or should we try reconnecting instead ?
Member
Author
There was a problem hiding this comment.
yup, this will exit the loop and the engine layer would trigger a resume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fixed a few edge cases with connection resumption. added tests