chore(deps): require stable z-engine releases instead of dev branches - #20
Merged
Merged
Conversation
z-engine now ships stable tags for both supported PHP minors (8.4.2 on the 8.4 line, 8.5.0 on the 8.5 line), so the development-branch constraint is no longer needed. - require "lisachenko/z-engine": "~8.4.2 || ~8.5.0" — one stable release line per supported PHP minor. The tilde admits patch releases inside a line but never the next minor line, which would be built for a PHP this package does not claim to support; each z-engine tag also declares its own ~8.4.0/~8.5.0 platform requirement, so only one line can ever satisfy a given runtime. - drop the root "minimum-stability": "dev" / "prefer-stable": true pair — nothing in require is a development branch any more, so consumers no longer need those flags to install this package's dependencies. - update README, CLAUDE.md, the CI comment and the code-reviewer agent (which still described the older "dev-master" + "~8.4.0" pins) to match. Verified on both minors with the functional suite: PHP 8.4.19 resolves z-engine 8.4.2 and PHP 8.5.9 resolves 8.5.0, 19/19 .phpt tests pass on each. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013foRd1XwLwqjUSkSWeWrMe
lisachenko
marked this pull request as ready for review
August 18, 2026 13:14
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
z-engine now ships stable tags for both supported PHP minors —
8.4.2on the 8.4 line and8.5.0on the 8.5 line — so this package no longer has to consume development branches."lisachenko/z-engine": "8.4.x-dev || 8.5.x-dev"→"~8.4.2 || ~8.5.0""minimum-stability": "dev"/"prefer-stable": truedroppedWhy the tilde and not a caret
The lockstep rule is unchanged: one z-engine release line per supported PHP minor.
~8.4.2admits patch releases inside the 8.4 line (8.4.3, …) but never the 8.5 line;~8.5.0does the same for 8.5. A caret (^8.4) would span both lines and any future one, so a z-engine built for PHP 8.6 would become installable here before this package claims to support 8.6.Resolution stays automatic and safe in both directions: each z-engine tag declares its own platform requirement (
~8.4.0for 8.4.x,~8.5.0for 8.5.x), so only one line can ever satisfy a given runtime, andCore::init()still enforces the exact match at boot.Dropping the stability pair is now correct because nothing in
requireis a development branch any more — consumers no longer needminimum-stability: devto install this package's dependencies. The install command in the README still asks fornative-php-matrix:dev-masterbecause this package itself is untagged; that explicit dev constraint carries its own stability flag and needs no root change.Relationship to #12
#12 (closed) asked for exactly this once a stable z-engine tag existed, and listed three steps. Two are done here — relax the constraint, drop the root-stability note from the README. It suggested a caret; this uses a tilde per line instead, for the reason above — a caret would have re-opened the door the version guard exists to keep shut. Its third step, tagging a native-php-matrix release so the package is normally installable from Packagist, is still outstanding and out of scope here.
Docs updated alongside
README.md— requirements + installation sectionCLAUDE.md— the non-negotiable version rule and the dependency policy (whose own "tighten this when z-engine ships stable releases" TODO this change discharges).github/workflows/ci.yml— the explanatory comment above the job matrix.claude/agents/code-reviewer.md— its version-pin gate still described the olderdev-master+"php": "~8.4.0"pins and would have rejected the current manifestTesting
Both minors, functional suite, locally:
.phptpass.phptpassNo segfaults or bus errors on either minor. CI is green on all five jobs.
Follow-up this unblocks (not in this PR)
Every
.phptcarrieserror_reporting=E_ALL & ~E_DEPRECATED, added because z-engine's dev line declared implicitly nullable parameters (ZEngine\Type\OpLine::__construct()). The stable releases declare them?Type, and the whole suite passes witherror_reporting=E_ALLforced on both minors — so that suppression can now be removed from the 19 test files in a separate, purely mechanical change.CLAUDE.mdis updated to record that it is belt-and-braces rather than a requirement.